Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hm, TM - what are these in reference to? #962

Closed
TheDigitalOrchard opened this issue Apr 18, 2024 · 9 comments
Closed

Hm, TM - what are these in reference to? #962

TheDigitalOrchard opened this issue Apr 18, 2024 · 9 comments
Milestone

Comments

@TheDigitalOrchard
Copy link
Contributor

💬 Question

Throughout the Cypht framework, there are classes prefixed with Hm_, and the Environment variables are stored with a prefix of TM_.

What are these in reference to? Legacy name? If so, can we deprecate these in favour of a Cypht_ \ CYPHT_ prefix?

@marclaporte
Copy link
Member

Context: #602

Yes, we should clean up!

If low risk, we sneak in 2.0, else 2.1 or 3.0

@marclaporte
Copy link
Member

@Shadow243 As you worked on #823 please opine.

@Shadow243
Copy link
Member

@Shadow243 As you worked on #823 please opine.

This is an option to take into consideration, however there is too much refactoring to do because this will affect all cypht modules, unit tests, lib and certain javascript files.

I would therefore suggest doing this in a version other than 2.0 which must already be released asap.

@marclaporte
Copy link
Member

and the Environment variables are stored with a prefix of TM_.

@Shadow243 what does TM stand for?

@Shadow243
Copy link
Member

Shadow243 commented Apr 18, 2024

TM

The idea of putting dotenv came from tiki manager, this TM surely came from there too (TIKI MANAGER) and so I didn't change it by putting something else, it could be CYPHT_

@marclaporte
Copy link
Member

This is an option to take into consideration, however there is too much refactoring to do because this will affect all cypht modules, unit tests, lib and certain javascript files.

Is this for Hm_, TM_ or both?

Cypht 2.0 has not been released yet so almost no one is using TM_ yet. So it could make sense to do before we release 2.0: #966

@Shadow243
Copy link
Member

This is an option to take into consideration, however there is too much refactoring to do because this will affect all cypht modules, unit tests, lib and certain javascript files.

Is this for Hm_, TM_ or both?

Cypht 2.0 has not been released yet so almost no one is using TM_ yet. So it could make sense to do before we release 2.0: #966

Copy that @marclaporte

@marclaporte
Copy link
Member

#967

@marclaporte
Copy link
Member

So this task is partly done, and the rest is covered by #602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants