chore(server): align test folder structure to src folder structure (#18597)

Author: emilyrohrbough

packages/server/lib/config.ts

@@ -17,7 +17,7 @@ import findSystemNode from './util/find_system_node'
 const debug = Debug('cypress:server:config')
 
 import { options, breakingOptions } from './config_options'
-import { getProcessEnvVars } from './util/config'
+import { getProcessEnvVars, CYPRESS_SPECIAL_ENV_VARS } from './util/config'
 
 export const RESOLVED_FROM = ['plugin', 'env', 'default', 'runtime', 'config'] as const
 
@@ -32,18 +32,6 @@ export type ResolvedConfigurationOptions = Partial<{
   [x in keyof Cypress.ResolvedConfigOptions]: ResolvedFromConfig
 }>
 
-export const CYPRESS_ENV_PREFIX = 'CYPRESS_'
-
-export const CYPRESS_ENV_PREFIX_LENGTH = 'CYPRESS_'.length
-
-export const CYPRESS_RESERVED_ENV_VARS = [
-  'CYPRESS_INTERNAL_ENV',
-]
-
-export const CYPRESS_SPECIAL_ENV_VARS = [
-  'RECORD_KEY',
-]
-
 const dashesOrUnderscoresRe = /^(_-)+/
 
 // takes an array and creates an index object of [keyKey]: [valueKey]

packages/server/lib/util/config.ts

@@ -1,11 +1,18 @@
 import _ from 'lodash'
-import {
-  CYPRESS_ENV_PREFIX,
-  CYPRESS_ENV_PREFIX_LENGTH,
-  CYPRESS_RESERVED_ENV_VARS,
-} from '../config'
 import { coerce } from './coerce'
 
+export const CYPRESS_ENV_PREFIX = 'CYPRESS_'
+
+export const CYPRESS_ENV_PREFIX_LENGTH = 'CYPRESS_'.length
+
+export const CYPRESS_RESERVED_ENV_VARS = [
+  'CYPRESS_INTERNAL_ENV',
+]
+
+export const CYPRESS_SPECIAL_ENV_VARS = [
+  'RECORD_KEY',
+]
+
 export const isDefault = (config: Record<string, any>, prop: string) => {
   return config.resolved[prop].from === 'default'
 }

packages/server/test/unit/browsers/browsers_spec.js

@@ -5,7 +5,7 @@ const utils = require(`${root}../lib/browsers/utils`)
 const snapshot = require('snap-shot-it')
 
 const normalizeBrowsers = (message) => {
-  return message.replace(/(found are: ).*/, '$1chrome, firefox, electron')
+  return message.replace(/(found on your system are:)((\n.*)*)/, '$1\n- chrome\n- firefox\n- electron')
 }
 
 // When we added component testing mode, we added the option for electron to be omitted

packages/server/test/unit/config_spec.js

@@ -2412,25 +2412,3 @@ describe('lib/config', () => {
     })
   })
 })
-
-describe('lib/util/config', () => {
-  context('.isDefault', () => {
-    it('returns true if value is default value', () => {
-      settings = { baseUrl: null }
-      const defaults = { baseUrl: null }
-      const resolved = {}
-      const merged = config.setResolvedConfigValues(settings, defaults, resolved)
-
-      expect(configUtil.isDefault(merged, 'baseUrl')).to.be.true
-    })
-
-    it('returns false if value is not default value', () => {
-      settings = { baseUrl: null }
-      const defaults = { baseUrl: 'http://localhost:8080' }
-      const resolved = {}
-      const merged = config.setResolvedConfigValues(settings, defaults, resolved)
-
-      expect(configUtil.isDefault(merged, 'baseUrl')).to.be.false
-    })
-  })
-})

packages/server/test/unit/args_spec.js packages/server/test/unit/util/args_spec.js

@@ -1,12 +1,12 @@
-require('../spec_helper')
+require('../../spec_helper')
 
 const path = require('path')
 const os = require('os')
 const snapshot = require('snap-shot-it')
 const stripAnsi = require('strip-ansi')
 const minimist = require('minimist')
-const argsUtil = require(`${root}lib/util/args`)
-const getWindowsProxyUtil = require(`${root}lib/util/get-windows-proxy`)
+const argsUtil = require(`${root}../lib/util/args`)
+const getWindowsProxyUtil = require(`${root}../lib/util/get-windows-proxy`)
 
 const cwd = process.cwd()
 

packages/server/test/unit/cache_buster_spec.js packages/server/test/unit/util/cache_buster_spec.js

@@ -1,6 +1,6 @@
-require('../spec_helper')
+require('../../spec_helper')
 
-const CacheBuster = require(`${root}lib/util/cache_buster`)
+const CacheBuster = require(`${root}../lib/util/cache_buster`)
 
 describe('lib/cache_buster', () => {
   context('#get', () => {

packages/server/test/unit/chrome_policy_check.js packages/server/test/unit/util/chrome_policy_check.js

@@ -1,8 +1,8 @@
-require('../spec_helper')
+require('../../spec_helper')
 
 const _ = require('lodash')
 const { stripIndent } = require('common-tags')
-const chromePolicyCheck = require(`${root}lib/util/chrome_policy_check`)
+const chromePolicyCheck = require(`${root}../lib/util/chrome_policy_check`)
 
 describe('lib/util/chrome_policy_check', () => {
   context('.getRunner returns a function', () => {

packages/server/test/unit/ci_provider_spec.js packages/server/test/unit/util/ci_provider_spec.js

@@ -1,8 +1,8 @@
 const mockedEnv = require('mocked-env')
 
-require('../spec_helper')
+require('../../spec_helper')
 
-const ciProvider = require(`${root}lib/util/ci_provider`)
+const ciProvider = require(`${root}../lib/util/ci_provider`)
 
 const expectsName = (name) => {
   expect(ciProvider.provider(), 'CI providers detected name').to.eq(name)

packages/server/test/unit/coerce_spec.js packages/server/test/unit/util/coerce_spec.js

@@ -1,7 +1,7 @@
-require('../spec_helper')
+require('../../spec_helper')
 
-const { coerce } = require(`${root}lib/util/coerce`)
-const { getProcessEnvVars } = require(`${root}lib/util/config`)
+const { coerce } = require(`${root}../lib/util/coerce`)
+const { getProcessEnvVars } = require(`${root}../lib/util/config`)
 
 describe('lib/util/coerce', () => {
   beforeEach(function () {

packages/server/test/unit/util/config_spec.js

@@ -0,0 +1,48 @@
+require('../../spec_helper')
+
+const configUtil = require(`${root}../lib/util/config`)
+
+describe('lib/util/config', () => {
+  context('.isDefault', () => {
+    it('returns true if value is default value', () => {
+      const options = {
+        resolved: {
+          baseUrl: { from: 'default' },
+        },
+      }
+
+      expect(configUtil.isDefault(options, 'baseUrl')).to.be.true
+    })
+
+    it('returns false if value is not default value', () => {
+      const options = {
+        resolved: {
+          baseUrl: { from: 'cli' },
+        },
+      }
+
+      expect(configUtil.isDefault(options, 'baseUrl')).to.be.false
+    })
+  })
+
+  context('.getProcessEnvVars', () => {
+    it('returns process envs prefixed with cypress', () => {
+      const envs = {
+        CYPRESS_BASE_URL: 'value',
+        RANDOM_ENV: 'ignored',
+      }
+
+      expect(configUtil.getProcessEnvVars(envs)).to.deep.eq({
+        BASE_URL: 'value',
+      })
+    })
+
+    it('does not return CYPRESS_RESERVED_ENV_VARS', () => {
+      const envs = {
+        CYPRESS_INTERNAL_ENV: 'value',
+      }
+
+      expect(configUtil.getProcessEnvVars(envs)).to.deep.eq({})
+    })
+  })
+})

packages/server/test/unit/duration_spec.js packages/server/test/unit/util/duration_spec.js

@@ -1,6 +1,6 @@
-require('../spec_helper')
+require('../../spec_helper')
 
-const duration = require(`${root}lib/util/duration`)
+const duration = require(`${root}../lib/util/duration`)
 
 describe('lib/util/duration', () => {
   context('.format', () => {

packages/server/test/unit/ensure_url_spec.ts packages/server/test/unit/util/ensure_url_spec.ts

@@ -1,7 +1,7 @@
-import '../spec_helper'
+import '../../spec_helper'
 
 import { connect, agent } from '@packages/network'
-import { isListening } from '../../lib/util/ensure-url'
+import { isListening } from '../../../lib/util/ensure-url'
 import sinon from 'sinon'
 import nock from 'nock'
 

packages/server/test/unit/file_spec.js packages/server/test/unit/util/file_spec.js

@@ -1,13 +1,13 @@
-require('../spec_helper')
+require('../../spec_helper')
 
 const os = require('os')
 const path = require('path')
 const Promise = require('bluebird')
 const lockFile = Promise.promisifyAll(require('lockfile'))
-const { fs } = require(`${root}lib/util/fs`)
-const env = require(`${root}lib/util/env`)
-const exit = require(`${root}lib/util/exit`)
-const FileUtil = require(`${root}lib/util/file`)
+const { fs } = require(`${root}../lib/util/fs`)
+const env = require(`${root}../lib/util/env`)
+const exit = require(`${root}../lib/util/exit`)
+const FileUtil = require(`${root}../lib/util/file`)
 
 describe('lib/util/file', () => {
   beforeEach(function () {

packages/server/test/unit/human_time_spec.js packages/server/test/unit/util/human_time_spec.js

@@ -1,7 +1,7 @@
-require('../spec_helper')
+require('../../spec_helper')
 
 const humanInterval = require('human-interval')
-const humanTime = require(`${root}lib/util/human_time`)
+const humanTime = require(`${root}../lib/util/human_time`)
 
 describe('lib/util/human_time', () => {
   context('.long', () => {

packages/server/test/unit/newlines_spec.ts packages/server/test/unit/util/newlines_spec.ts

@@ -1,6 +1,6 @@
-import '../spec_helper'
+import '../../spec_helper'
 
-import newlines from '../../lib/util/newlines'
+import newlines from '../../../lib/util/newlines'
 
 describe('lib/util/newlines', function () {
   it('inserts newline at each n char', function () {

packages/server/test/unit/open_spec.js packages/server/test/unit/util/open_spec.js

@@ -1,7 +1,7 @@
-require('../spec_helper')
+require('../../spec_helper')
 
 const cp = require('child_process')
-const open = require(`${root}lib/util/open`)
+const open = require(`${root}../lib/util/open`)
 
 const platform = (p) => {
   return Object.defineProperty(process, 'platform', {

packages/server/test/unit/origin_spec.js packages/server/test/unit/util/origin_spec.js

@@ -1,6 +1,6 @@
-require('../spec_helper')
+require('../../spec_helper')
 
-const origin = require(`${root}lib/util/origin`)
+const origin = require(`${root}../lib/util/origin`)
 
 describe('lib/util/origin', () => {
   beforeEach(function () {

packages/server/test/unit/path_helpers_spec.js packages/server/test/unit/util/path_helpers_spec.js

@@ -1,6 +1,6 @@
-require('../spec_helper')
+require('../../spec_helper')
 
-const path_helpers = require(`${root}lib/util/path_helpers`)
+const path_helpers = require(`${root}../lib/util/path_helpers`)
 
 describe('lib/util/path_helpers', () => {
   context('checkIfResolveChangedRootFolder', () => {

packages/server/test/unit/profile_cleaner_spec.js packages/server/test/unit/util/profile_cleaner_spec.js

@@ -1,10 +1,10 @@
-require('../spec_helper')
+require('../../spec_helper')
 
 const os = require('os')
 const path = require('path')
-const { fs } = require(`${root}/lib/util/fs`)
-const findProcess = require(`${root}lib/util/find_process`)
-const profileCleaner = require(`${root}lib/util/profile_cleaner`)
+const { fs } = require(`${root}../lib/util/fs`)
+const findProcess = require(`${root}../lib/util/find_process`)
+const profileCleaner = require(`${root}../lib/util/profile_cleaner`)
 
 const tmpDir = os.tmpdir()
 const pidProfilesFolder = path.join(tmpDir, 'pid-profiles')

packages/server/test/unit/random_spec.js packages/server/test/unit/util/random_spec.js

@@ -1,7 +1,7 @@
-require('../spec_helper')
+require('../../spec_helper')
 
 const randomstring = require('randomstring')
-const random = require(`${root}lib/util/random`)
+const random = require(`${root}../lib/util/random`)
 
 context('.id', () => {
   it('returns random.generate string with length 5 by default', () => {

packages/server/test/unit/routes_util_spec.js packages/server/test/unit/util/routes_spec.js

@@ -1,6 +1,6 @@
-require('../spec_helper')
+require('../../spec_helper')
 
-const { apiRoutes, onRoutes } = require(`${root}/lib/util/routes`)
+const { apiRoutes, onRoutes } = require(`${root}../lib/util/routes`)
 
 describe('lib/util/routes', () => {
   describe('api routes', () => {

packages/server/test/unit/specs_spec.js packages/server/test/unit/util/specs_spec.js

@@ -1,9 +1,9 @@
-require('../spec_helper')
+require('../../spec_helper')
 
 const R = require('ramda')
 const path = require('path')
-const config = require(`${root}lib/config`)
-const specsUtil = require(`${root}lib/util/specs`).default
+const config = require(`${root}../lib/config`)
+const specsUtil = require(`${root}../lib/util/specs`).default
 const FixturesHelper = require('@tooling/system-tests/lib/fixtures')
 const debug = require('debug')('test')
 

packages/server/test/unit/stream_buffer_spec.js packages/server/test/unit/util/stream_buffer_spec.js

@@ -1,11 +1,11 @@
-require('../spec_helper')
+require('../../spec_helper')
 
 const _ = require('lodash')
 const fs = require('fs')
 const stream = require('stream')
 const Promise = require('bluebird')
 const { concatStream } = require('@packages/network')
-const { streamBuffer } = require('../../lib/util/stream_buffer')
+const { streamBuffer } = require('../../../lib/util/stream_buffer')
 
 function drain (stream) {
   return new Promise((resolve) => {

packages/server/test/unit/suppress_warnings_spec.ts packages/server/test/unit/util/suppress_warnings_spec.ts

@@ -1,12 +1,12 @@
-import '../spec_helper'
+import '../../spec_helper'
 import { expect } from 'chai'
 import execa from 'execa'
 import proxyquire from 'proxyquire'
 
 const ERROR_MESSAGE = 'Setting the NODE_TLS_REJECT_UNAUTHORIZED'
 
 const TLS_CONNECT = `require('tls').connect().on('error', ()=>{});`
-const SUPPRESS_WARNING = `require('${__dirname}/../../lib/util/suppress_warnings').suppress();`
+const SUPPRESS_WARNING = `require('${__dirname}/../../../lib/util/suppress_warnings').suppress();`
 
 describe('lib/util/suppress_warnings', function () {
   it('tls.connect emits warning if NODE_TLS_REJECT_UNAUTHORIZED=0 and not suppressed', function () {
@@ -36,7 +36,7 @@ describe('lib/util/suppress_warnings', function () {
     const emitWarning = sinon.spy(process, 'emitWarning')
 
     // force typescript to always be non-requireable
-    const { suppress } = proxyquire('../../lib/util/suppress_warnings', {})
+    const { suppress } = proxyquire('../../../lib/util/suppress_warnings', {})
 
     suppress()
 

packages/server/test/unit/terminal_spec.js packages/server/test/unit/util/terminal_spec.js

@@ -1,11 +1,11 @@
-require('../spec_helper')
+require('../../spec_helper')
 
 const snapshot = require('snap-shot-it')
 const stripAnsi = require('strip-ansi')
 const widestLine = require('widest-line')
-const env = require(`${root}lib/util/env`)
-const terminal = require(`${root}lib/util/terminal`)
-const terminalSize = require(`${root}lib/util/terminal-size`)
+const env = require(`${root}../lib/util/env`)
+const terminal = require(`${root}../lib/util/terminal`)
+const terminalSize = require(`${root}../lib/util/terminal-size`)
 
 const sanitizeSnapshot = (str) => {
   return snapshot(stripAnsi(str))

packages/server/test/unit/trash_spec.js packages/server/test/unit/util/trash_spec.js

@@ -1,9 +1,9 @@
-require('../spec_helper')
+require('../../spec_helper')
 
 const fs = require('fs')
 const os = require('os')
 const path = require('path')
-const trash = require(`${root}lib/util/trash`)
+const trash = require(`${root}../lib/util/trash`)
 
 const populateDirectories = function (basePath) {
   fs.mkdirSync(basePath)