Remove incorrect typing for Cypress.Commands.overwrite - does not accept options (#5347)

jennifer-shehane · brian-mann · commit 89ceb7ac4520 · 2019-10-11T19:21:01.000-04:00
* Remove incorrect typing for Cypress.Commands.overwrite - does not accept options

* remove test that accepted options
diff --git a/cli/types/index.d.ts b/cli/types/index.d.ts
@@ -292,7 +292,6 @@ declare namespace Cypress {
       add(name: string, fn: (...args: any[]) => void): void
       add(name: string, options: CommandOptions, fn: (...args: any[]) => void): void
       overwrite(name: string, fn: (...args: any[]) => void): void
-      overwrite(name: string, options: CommandOptions, fn: (...args: any[]) => void): void
     }
 
     /**
diff --git a/cli/types/tests/cypress-tests.ts b/cli/types/tests/cypress-tests.ts
@@ -61,9 +61,6 @@ namespace CypressCommandsTests {
   Cypress.Commands.overwrite('newCommand', () => {
     return
   })
-  Cypress.Commands.overwrite('newCommand', { prevSubject: true }, () => {
-    return
-  })
 }
 
 namespace CypressLogsTest {

Original file line number	Diff line number	Diff line change
`@@ -292,7 +292,6 @@ declare namespace Cypress {`
`292`	`292`	`add(name: string, fn: (...args: any[]) => void): void`
`293`	`293`	`add(name: string, options: CommandOptions, fn: (...args: any[]) => void): void`
`294`	`294`	`overwrite(name: string, fn: (...args: any[]) => void): void`
`295`		`- overwrite(name: string, options: CommandOptions, fn: (...args: any[]) => void): void`
`296`	`295`	`}`
`297`	`296`
`298`	`297`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -61,9 +61,6 @@ namespace CypressCommandsTests {`
`61`	`61`	`Cypress.Commands.overwrite('newCommand', () => {`
`62`	`62`	`return`
`63`	`63`	`})`
`64`		`- Cypress.Commands.overwrite('newCommand', { prevSubject: true }, () => {`
`65`		`- return`
`66`		`- })`
`67`	`64`	`}`
`68`	`65`
`69`	`66`	`namespace CypressLogsTest {`