chore: make launcher an independent package

Author: AtofStryker

guides/esm-migration.md

@@ -50,7 +50,7 @@ When migrating some of these projects away from the `ts-node` entry [see `@packa
 - [x] packages/electron ✅ **COMPLETED**
 - [ ] packages/https-proxy **PARTIAL** - entry point is JS
 - [x] packages/icons ✅ **COMPLETED**
-- [x] packages/launcher ✅ **COMPLETED** (needs independent bundle but lower priority)
+- [x] packages/launcher ✅ **COMPLETED**
 - [x] packages/launchpad ✅ **COMPLETED**
 - [x] packages/net-stubbing ✅ **COMPLETED**
 - [ ] packages/network **PARTIAL** - entry point is JS

packages/launcher/.eslintignore

@@ -1,4 +1,5 @@
-**/dist
+**/cjs
+**/esm
 **/*.d.ts
 **/package-lock.json
 **/tsconfig.json

packages/launcher/.gitignore

@@ -0,0 +1,2 @@
+cjs/
+esm/

packages/launcher/index.ts

@@ -4,6 +4,7 @@ import execa from 'execa'
 import fs from 'fs-extra'
 import path from 'path'
 import plist from 'plist'
+import type { PlistValue } from 'plist'
 
 const debugVerbose = Debug('cypress-verbose:launcher:darwin:util')
 
@@ -25,9 +26,9 @@ export async function parsePlist (p: string, property: string): Promise<string>
     const file = await fs.readFile(pl, 'utf8')
     const val = plist.parse(file)
 
-    return String(val[property]) // explicitly convert value to String type
+    return String(val[property as keyof PlistValue]) // explicitly convert value to String type
   } catch (err) {
-    return failed(err) // to make TS compiler happy
+    return failed(err as Error) // to make TS compiler happy
   }
 }
 

packages/launcher/lib/darwin/util.ts

@@ -1,6 +1,5 @@
-import _, { compact, extend, find } from 'lodash'
+import _, { compact, extend, find, uniqBy } from 'lodash'
 import os from 'os'
-import { removeDuplicateBrowsers } from '@packages/data-context/src/sources/BrowserDataSource'
 import { knownBrowsers } from './known-browsers'
 import * as darwinHelper from './darwin'
 import { notDetectedAtPathErr } from './errors'
@@ -26,8 +25,16 @@ type HasVersion = Omit<Partial<FoundBrowser>, 'version' | 'name'> & {
   name: string
 }
 
+function getBrowserKey<T extends {name: string, version: string | number}> (browser: T) {
+  return `${browser.name}-${browser.version}`
+}
+
+function removeDuplicateBrowsers (browsers: FoundBrowser[]) {
+  return uniqBy(browsers, getBrowserKey)
+}
+
 export const getMajorVersion = (version: string): string => {
-  return version.split('.')[0]
+  return version.split('.')[0] as string
 }
 
 // Determines if found browser is supported by Cypress. If found to be
@@ -199,7 +206,7 @@ export const detectByPath = async (
     })
   }
 
-  const detectBrowserFromKey = (browserKey): Browser | undefined => {
+  const detectBrowserFromKey = (browserKey: string): Browser | undefined => {
     return find(goalBrowsers, (goalBrowser) => {
       return (
         goalBrowser.name === browserKey ||

packages/launcher/lib/detect.ts

@@ -0,0 +1,9 @@
+import { detect, detectByPath } from './detect'
+
+import { launch } from './browsers'
+
+export {
+  detect,
+  detectByPath,
+  launch,
+}

packages/launcher/lib/index.ts

@@ -115,7 +115,7 @@ async function getLinuxBrowser (
 
     return foundBrowser as FoundBrowser
   } catch (err) {
-    return logAndThrowError(err)
+    return logAndThrowError(err as Error)
   }
 }
 

packages/launcher/lib/linux/index.ts

@@ -56,7 +56,7 @@ function formChromeForTestingAppPath () {
   ].map(normalize)
 }
 
-function getFirefoxPaths (editionFolder) {
+function getFirefoxPaths (editionFolder: string) {
   return () => {
     return (['Program Files', 'Program Files (x86)'])
     .map((programFiles) => {
@@ -134,7 +134,7 @@ function getWindowsBrowser (browser: Browser): Promise<FoundBrowser> {
   debugVerbose('looking at possible paths... %o', { browser, exePaths })
 
   // shift and try paths 1-by-1 until we find one that works
-  const tryNextExePath = async () => {
+  const tryNextExePath = async (): Promise<FoundBrowser> => {
     const exePath = exePaths.shift()
 
     if (!exePath) {
@@ -180,12 +180,18 @@ export function doubleEscape (s: string) {
   return win32.join(...s.split(win32.sep)).replace(/\\/g, '\\\\')
 }
 
-export function getVersionString (path: string) {
+export function getVersionString (path: string): Promise<string> {
   // on Windows using "--version" seems to always start the full
   // browser, no matter what one does.
 
   try {
-    return Promise.resolve(winVersionInfo(path).FileVersion)
+    const fileVersion = winVersionInfo(path).FileVersion
+
+    if (!fileVersion) {
+      throw new Error(`Failed to get version string for ${path}`)
+    }
+
+    return Promise.resolve(fileVersion)
   } catch (err) {
     return Promise.reject(err)
   }

packages/launcher/lib/windows/index.ts

@@ -2,12 +2,14 @@
   "name": "@packages/launcher",
   "version": "0.0.0-development",
   "private": true,
+  "main": "./cjs/index.js",
   "scripts": {
-    "build-prod": "tsc --project .",
-    "check-ts": "tsc --noEmit && yarn -s tslint",
-    "clean": "rimraf --glob 'lib/*.js' && rimraf --glob 'lib/**/*.js' || true",
+    "build": "yarn build:cjs && yarn build:esm",
+    "build-prod": "yarn build",
+    "build:cjs": "tsc -p tsconfig.cjs.json",
+    "build:esm": "tsc -p tsconfig.esm.json",
+    "check-ts": "tsc --noEmit -p tsconfig.cjs.json && tsc --noEmit -p tsconfig.esm.json && yarn -s tslint -p tsconfig.cjs.json",
     "clean-deps": "rimraf node_modules",
-    "clean-js": "yarn clean",
     "lint": "eslint --ext .js,.jsx,.ts,.tsx,.json, .",
     "size": "t=\"cypress-v0.0.0.tgz\"; yarn pack --filename \"${t}\"; wc -c \"cli/${t}\"; tar tvf \"${t}\"; rm \"${t}\";",
     "test": "yarn test-unit",
@@ -29,15 +31,18 @@
     "@packages/data-context": "0.0.0-development",
     "@packages/ts": "0.0.0-development",
     "@packages/types": "0.0.0-development",
+    "@types/plist": "^3.0.5",
+    "@types/win-version-info": "^3.1.3",
     "mock-fs": "5.4.0",
     "typescript": "~5.4.5",
     "vitest": "^3.2.4"
   },
   "files": [
-    "index.js",
-    "lib"
+    "cjs/*",
+    "esm/*"
   ],
-  "types": "index.ts",
+  "types": "./cjs/index.d.ts",
+  "module": "./esm/index.js",
   "nx": {
     "implicitDependencies": [
       "@packages/data-context"