Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference in name vs displayName between Mac and Linux #1017

Closed
bahmutov opened this issue Dec 6, 2017 · 1 comment
Closed

Difference in name vs displayName between Mac and Linux #1017

bahmutov opened this issue Dec 6, 2017 · 1 comment
Assignees
Labels
browser: chrome OS: linux stage: wontfix Cypress does not regard this as an issue or will not implement this feature

Comments

@bahmutov
Copy link
Contributor

bahmutov commented Dec 6, 2017

bug

Cypress 1.1.3

List of detected browsers on Mac shows for each browser name and displayName

$ cd packages/launcher
$ node index.js 
Launcher project exports
{ [Function: init]
  update: [Function: update],
  detect: [Function: detectBrowsers] }
⛔️ please use it as a module, not from CLI
detected 3 browsers
[ { name: 'chrome',
    displayName: 'Chrome',
    version: '62.0.3202.94',
    path: '/Applications/Google Chrome.app/Contents/MacOS/Google Chrome',
    majorVersion: '62' },
  { name: 'chromium',
    displayName: 'Chromium',
    version: '60.0.3110.0',
    path: '/Applications/Chromium.app/Contents/MacOS/Chromium',
    majorVersion: '60' },
  { name: 'canary',
    displayName: 'Canary',
    version: '65.0.3286.0',
    path: '/Applications/Google Chrome Canary.app/Contents/MacOS/Google Chrome Canary',
    majorVersion: '65' } ]

but on Linux we get

detected 1 browser
[ { name: 'Google Chrome (alias)',
    version: '62.0.3202.62',
    path: 'chrome',
    majorVersion: '62' } ]

Linux should also return name and displayName correctly.

@brian-mann
Copy link
Member

This is a non-issue - we are removing alias support from launcher.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser: chrome OS: linux stage: wontfix Cypress does not regard this as an issue or will not implement this feature
Projects
None yet
Development

No branches or pull requests

3 participants