Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate readonly fields #1246

Closed
pedromatos47 opened this issue Feb 1, 2018 · 7 comments · Fixed by #4729 or #4783
Closed

Validate readonly fields #1246

pedromatos47 opened this issue Feb 1, 2018 · 7 comments · Fixed by #4729 or #4783
Assignees
@jennifer-shehane
Labels
good first issue Good for newcomers pkg/driver This is due to an issue in the packages/driver directory

Comments

@pedromatos47
Copy link

Since Cypress doesn't support readonly attribute validation as of now, is there any way to work around it?

And would it be to much of a hassle to add this feature?

Cheers
@brian-mann
Copy link
Member

PR's accepted! This would be rather simple to implement.

@jennifer-shehane
Copy link
Member

jennifer-shehane commented Feb 9, 2018 •
edited
Loading

.type() code is here, it should likely throw an err if the input is readonly unless opt force is true: https://github.com/cypress-io/cypress/blob/develop/packages/driver/src/cy/commands/actions/type.coffee#L23

@jennifer-shehane jennifer-shehane added pkg/driver This is due to an issue in the packages/driver directory good first issue Good for newcomers stage: ready for work The issue is reproducible and in scope labels Feb 9, 2018
@pedromatos47
Copy link
Author

@jennifer-shehane @brian-mann Thank you for your feedback! 🙂

@jennifer-shehane jennifer-shehane mentioned this issue Jul 16, 2019
Merged
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress labels Jul 16, 2019
@jennifer-shehane jennifer-shehane self-assigned this Jul 16, 2019
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Jul 18, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 18, 2019

The code for this is done in cypress-io/cypress#4729, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@brian-mann
Copy link
Member

Reopening per my comments here: #4729 (comment)

@brian-mann brian-mann reopened this Jul 22, 2019
@jennifer-shehane jennifer-shehane mentioned this issue Jul 23, 2019
Merged
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: pending release labels Jul 23, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 23, 2019

The code for this is done in cypress-io/cypress#4783, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Jul 23, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 29, 2019

Released in 3.4.1.

@snyk-bot snyk-bot mentioned this issue Nov 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jennifer-shehane jennifer-shehane

Labels
good first issue Good for newcomers pkg/driver This is due to an issue in the packages/driver directory
Projects
None yet
Milestone
No milestone
3 participants
@brian-mann @jennifer-shehane @pedromatos47