feat: rename delayMs to delay, deprecate delay #14822
Conversation
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
| @@ -43,9 +43,17 @@ export function validateStaticResponse (cmd: string, staticResponse: StaticRespo | |||
| err('`throttleKbps` must be a finite, positive number.') | |||
| } | |||
|
|
|||
| if (delayMs && delay) { | |||
| err('`delayMs` and `delay` cannot both be set.') | |||
There was a problem hiding this comment.
Should this be more like "delayMs has been deprecated. Use delay instead.`"?
There was a problem hiding this comment.
Hmm, I tried thinking of a better error, but it's backwards-compatible so the wording is tricky. I think this wording is prob fine - we still support delayMs, so this is the most accurate error. In the future when delayMs is removed it can be updated.
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
User facing changelog
delayMsoption forStaticResponses used withcy.intercepthas been renamed todelay.Additional details
How has the user experience changed?
PR Tasks
cypress-documentation? docs: delayMs -> delay cypress-documentation#3526type definitions?cypress.schema.json?