feat(@cypress/react): Support react-scripts v4 #15488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||
lmiller1990
approved these changes
Mar 16, 2021
agg23
reviewed
Mar 16, 2021
| @@ -10,7 +11,7 @@ describe('RemotePizza', () => { | |||
| 'pizza', | |||
| ) | |||
|
|
|||
| mount(<RemotePizza />) | |||
| mount(<RemotePizza />, { ReactDom }) | |||
There was a problem hiding this comment.
Why is the ReactDom instance different?
There was a problem hiding this comment.
I described this in slack channel. It is because mount function is in the upper directory and linked using file:../
There was a problem hiding this comment.
Can you document this in the test so it's clear?
This was referenced Mar 18, 2021
This was referenced Mar 18, 2021
Closed
elevatebart
pushed a commit
that referenced
this pull request
Mar 18, 2021
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore ReactRefresh using special env variable
Reference cypress-io/cypress-realworld-app#832