-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting Electron Dimensions Does Not Work In CI #15730
Comments
I see that this is actually mentioned in https://www.cypress.io/blog/2021/03/01/generate-high-resolution-videos-and-screenshots/ |
Yeah...we have had people report the effects of Electron headless sizing not taking effect. #587 We are working on a PR to make the default size larger for all sizes so that this configuration is not necessary for those that just want high resolution videos/screenshots. #15686 I'm hoping some insight will come out of that on how to configure specific sizes. |
this will be fixed in #15686 |
The code for this is done in cypress-io/cypress#15686, but has yet to be released. |
Released in v7.0.0 |
Thanks all, our recordings look great in 7.0.0. Will be upgrading after performance issues are sorted out. |
Current behavior
I was following the instructions at https://docs.cypress.io/api/plugins/browser-launch-api#Set-screen-size-when-running-headless to try to set the Electron headless dimensions when running in CI because at the moment the videos are very low quality. I have copied the exact code shown and it works fine locally but does not seem to have any affect when running on TeamCity. I've previously been doing this with Chrome and it worked fine but Electron does not work on CI for some reason.
Desired behavior
I would like any way to have decent looking recordings when setting the Electron viewport to 1367x768, currently the recording sidebar takes almost half the screen and I can't really see the browser view.
Test code to reproduce
index.js
cypress.json
Versions
6.8.0
The text was updated successfully, but these errors were encountered: