-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show tooltips for "info" property of browsers #21769
Comments
➤ Mark Noonan commented: Ryan Wilke Could we confirm - for the “info” version of the tooltip that appears over an unsupported browser, would we use the same question mark icon, or something else? And since the browser with an info notice would not be disabled, is it safe to make the icon the same color as the primary text? Brian Mann is there ever a situation where a browser might be both unsupported and have an info message, causing us to need two icons at the same time? I can’t think of one. |
The code for this is done in cypress-io/cypress#23711, but has yet to be released. |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Summary
It seems like these should look and work just like our tooltips for unsupported browsers but we should validate with Design team. For example, should the icon be different for info vs unsupported? Jennifer mentions different states in this slack thread that provides some context, as well as this message as the starting point.
See the icon in the top right of the image below, and the existing implementation and usage of the
UnsupportedBrowserTooltip
component, which can be renamed/extended to cover this case.There are 3 places users should see these info messages:
Based on a test in develop called “shows info icon with linkified tooltip”, the general tooltip created from UnsupportedBrowserTooltip.vue should also support markdown for linking. 9.0 implementation uses
MarkdownRenderer
for this, in 10.0 our existinguseMarkdown
composable can be used to wrap the info/warning values.Acceptance Criteria
info
property of a browser contains a message, a user can see that there is a message with an icon in the UI, and click the icon to open that message in a the UI.Resources
Any Notion documents, Google documents, Figma Boards
Open Pull Requests
Any PRs needed for review
┆Issue is synchronized with this Jira Task by Unito
┆Attachments: Screen Shot 2022-03-17 at 4.59.41 PM.png
┆author: Mark Noonan
┆epic: UI/UX Improvements
┆friendlyId: UNIFY-1378
┆priority: Highest
┆sprint: Unification Release Backlog
┆taskType: Task
The text was updated successfully, but these errors were encountered: