Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'create new empty spec' messaging. #21908

Closed
sync-by-unito bot opened this issue May 30, 2022 · 3 comments · Fixed by #25271
Closed

Update 'create new empty spec' messaging. #21908

sync-by-unito bot opened this issue May 30, 2022 · 3 comments · Fixed by #25271

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented May 30, 2022

Summary

There’s an option for E2E and CT to ‘Create new empty spec’. But this doesn’t actually create an ‘empty’ specfile. It creates a file with some code for cy.visit or cy.mount.

Screen Shot 2022-05-13 at 10 21 42 AM

Screen Shot 2022-05-13 at 10 14 26 AM

Screen Shot 2022-05-13 at 10 13 20 AM

Acceptance Criteria

  • We should update the wording of the ‘empty’ spec area. I’m not sure what it should say.

┆Issue is synchronized with this Jira Task by Unito
┆Attachments: Screen Shot 2022-05-13 at 10.13.20 AM.png | Screen Shot 2022-05-13 at 10.14.26 AM.png | Screen Shot 2022-05-13 at 10.21.42 AM.png
┆author: Jennifer Shehane
┆epic: UI/UX Improvements
┆friendlyId: UNIFY-1759
┆priority: Medium
┆sprint: Backlog
┆taskType: Task

@sainthkh
Copy link
Contributor

@jennifer-shehane

How about calling it a starter spec?

In WordPress, some themes that provides basic structure for the developers are called starter themes.

@Manuel-Suarez-Abascal
Copy link
Contributor

@sainthkh I have opened a PR for the requested change here. Let me know your thoughts on it.

@cypress-bot cypress-bot bot added the stage: needs review The PR code is done & tested, needs review label Dec 26, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 3, 2023

Released in 12.3.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.3.0, please open a new issue.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Jan 3, 2023
@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jan 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants