Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cy.type should follow activeElement #2240

Closed
kuceb opened this issue Jul 30, 2018 · 3 comments · Fixed by #4870
Closed

cy.type should follow activeElement #2240

kuceb opened this issue Jul 30, 2018 · 3 comments · Fixed by #4870
Assignees
@kuceb
Labels
topic: cy.type ⌨️ type: enhancement Requested enhancement of existing feature

Comments

@kuceb
Copy link
Contributor

kuceb commented Jul 30, 2018 •
edited
Loading

During cy.type(), if a typeable element is focused other than the command's subject, Cypress should start typing into the newly focused element

This is a patch change, despite cypress behavior changing, because previously cy.type would continue to type into the subject, despite other elements gaining focus
@kuceb kuceb self-assigned this Jul 30, 2018
@kuceb kuceb added this to the 4.0.0 milestone Jul 30, 2018
@kuceb kuceb added type: enhancement Requested enhancement of existing feature type: breaking change Requires a new major release version labels Jul 30, 2018
@kuceb kuceb changed the title cy.type should follow focus cy.type should follow activeElement Jul 30, 2018
@jennifer-shehane jennifer-shehane removed this from the 4.0.0 milestone Nov 13, 2018
@jennifer-shehane jennifer-shehane added topic: cy.type ⌨️ stage: ready for work The issue is reproducible and in scope labels Jul 13, 2019
@kuceb kuceb mentioned this issue Oct 22, 2019
Merged
17 tasks
@kuceb kuceb removed the type: breaking change Requires a new major release version label Oct 22, 2019
@kuceb
Copy link
Contributor Author

kuceb commented Oct 22, 2019

updated as non-breaking since this is a bug fix

@kuceb kuceb mentioned this issue Oct 22, 2019
Closed
@cypress-bot cypress-bot bot added stage: work in progress and removed stage: ready for work The issue is reproducible and in scope labels Oct 23, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 23, 2019

The code for this is done in cypress-io/cypress#4870, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 23, 2019

Released in 3.5.0.

@snyk-bot snyk-bot mentioned this issue Nov 1, 2019
Merged
@snyk-bot snyk-bot mentioned this issue Nov 9, 2019
Closed
@cypress-io cypress-io locked as resolved and limited conversation to collaborators Jan 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kuceb kuceb

Labels
topic: cy.type ⌨️ type: enhancement Requested enhancement of existing feature
Projects
None yet
Milestone
No milestone
2 participants
@jennifer-shehane @kuceb