Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

experimentalWebKitSupport: Fix proxying of Cypress internal websocket #23807

Closed
flotwig opened this issue Sep 13, 2022 · 2 comments
Closed

experimentalWebKitSupport: Fix proxying of Cypress internal websocket #23807

flotwig opened this issue Sep 13, 2022 · 2 comments
Labels
browser: webkit Issue related to Webkit (Safari) browser experiment: webkit Issues when using experimentalWebkitSupport stale no activity on this issue for a long period type: bug

Comments

@flotwig
Copy link
Contributor

flotwig commented Sep 13, 2022

Normally, browsers use the websocket socket.io transport to do IPC with the Cypress server.

For some unknown reason, the websocket (__socket) does not work in WebKit, and so we must use polling instead.

This is bad because the Developer Tools are flooded with xhr poll requests for __socket. Also, it breaks SocketAllowed with WebKit.

Other websockets, and __socket_graphql, seem to work fine.

Only the websocket transport should be used for IPC in WebKit.
@flotwig flotwig added browser: webkit Issue related to Webkit (Safari) browser experiment: webkit Issues when using experimentalWebkitSupport labels Sep 13, 2022
This was referenced Sep 13, 2022
Closed
Closed
@flotwig flotwig mentioned this issue Oct 12, 2022
Merged
2 tasks
@github-actions
Copy link
Contributor

This issue has not had any activity in 180 days. Cypress evolves quickly and the reported behavior should be tested on the latest version of Cypress to verify the behavior is still occurring. It will be closed in 14 days if no updates are provided.

@github-actions github-actions bot added the stale no activity on this issue for a long period label Apr 13, 2023
@github-actions
Copy link
Contributor

This issue has been closed due to inactivity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
browser: webkit Issue related to Webkit (Safari) browser experiment: webkit Issues when using experimentalWebkitSupport stale no activity on this issue for a long period type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flotwig