Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

experimentalWebKitSupport: Set devicePixelRatio #23808

Open
flotwig opened this issue Sep 13, 2022 · 3 comments
Open

experimentalWebKitSupport: Set devicePixelRatio #23808

flotwig opened this issue Sep 13, 2022 · 3 comments
Labels
browser: webkit Issue related to Webkit (Safari) browser E2E Issue related to end-to-end testing experiment: webkit Issues when using experimentalWebkitSupport prevent-stale mark an issue so it is ignored by stale[bot] Triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team.

Comments

@flotwig
Copy link
Contributor

flotwig commented Sep 13, 2022 •
edited
Loading

In other browsers, we set a standard devicePixelRatio. One reason for this is so that screenshot diffs can match whether a user runs them locally with 2x DPI or in CI with 1x DPI. It also causes fuzzy text on 2x displays:
image

This also needs to be set in WebKit.
@flotwig flotwig added good first issue Good for newcomers browser: webkit Issue related to Webkit (Safari) browser experiment: webkit Issues when using experimentalWebkitSupport labels Sep 13, 2022
@flotwig flotwig mentioned this issue Sep 13, 2022
Closed
21 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Apr 13, 2023 •
edited by nagash77
Loading

placeholder

@github-actions github-actions bot added the stale no activity on this issue for a long period label Apr 13, 2023
@emilyrohrbough emilyrohrbough added help wanted prevent-stale mark an issue so it is ignored by stale[bot] and removed stale no activity on this issue for a long period labels Apr 14, 2023
@bitcoinBandit1234
Copy link

It seems no one has taken this issue. can you please elaborate a bit on how you want the "devicePixelRatio" to be handled?

@nagash77 nagash77 added E2E Issue related to end-to-end testing Triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team. labels Jul 12, 2023
@nagash77
Copy link
Contributor

Hi @bitcoinBandit1234 are you interested in picking up this ticket and opening a PR?

@nagash77 nagash77 self-assigned this Jul 12, 2023
@nagash77 nagash77 removed their assignment Jul 27, 2023
@jennifer-shehane jennifer-shehane removed the good first issue Good for newcomers label Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
browser: webkit Issue related to Webkit (Safari) browser E2E Issue related to end-to-end testing experiment: webkit Issues when using experimentalWebkitSupport prevent-stale mark an issue so it is ignored by stale[bot] Triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nagash77 @flotwig @jennifer-shehane @emilyrohrbough @bitcoinBandit1234