Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Scrolling goes disabled automatically when the execution is in-progress #24015

Closed
vasanthiraman opened this issue Sep 28, 2022 · 11 comments
Closed

Comments

@vasanthiraman
Copy link

Current behavior

Auto-Scrolling goes disabled automatically when the execution is in-progress

Desired behavior

Auto Scrolling should remain enabled once it is on in cinfiguration. It should not go disabled automatically until the user manually disable it.

Test code to reproduce

N/A

Cypress Version

10.6.0

Node version

v14.16.0

Operating System

Windows 10

Debug Logs

No response

Other

No response

@lucasdonato
Copy link

I'm sad about this error too

@astone123 astone123 self-assigned this Sep 28, 2022
@astone123
Copy link
Contributor

@vasanthiraman @lucasdonato This sounds like a similar issue to #16098. We released a fix for this in version 10.8.0. Could you try upgrading Cypress to 10.8.0 and see if the issue persists? Thanks

@cypress-bot cypress-bot bot added the stage: awaiting response Potential fix was proposed; awaiting response label Sep 28, 2022
@lucasdonato
Copy link

I'm on version 10.9 and I have the same problem

@astone123
Copy link
Contributor

@lucasdonato can you make it happen reliably, or does it only happen intermittently?

@lucasdonato
Copy link

lucasdonato commented Sep 29, 2022

it happen reliably :(

@astone123
Copy link
Contributor

@lucasdonato can you share more information? This bug has been difficult for us to pin down because we haven't been able to trigger it on demand. If you could share a project that reliably reproduces the issue, that would be extremely helpful. Thanks

@romankhomitskyi
Copy link

romankhomitskyi commented Sep 29, 2022

This happens in open mode
Every time I rerurn my spec Auto scrolling is turned off

Cypress 10.9

@astone123
Copy link
Contributor

@romankhomitskyi could you provide an example project that can reproduce the issue reliably? That would allow me to take action on this. Thanks!

@romankhomitskyi
Copy link

@romankhomitskyi could you provide an example project that can reproduce the issue reliably? That would allow me to take action on this. Thanks!

Unfortunately, I could not

@marktnoonan
Copy link
Contributor

I wonder if we could act on this by adding some more guards around what is considered "user scrolling". The root cause of this seems to be that in certain situations, elements being added to the command log, and cypress autoscrolling, get interpreted as user scrolling. A user taking control by scrolling the command log to look at something while a test is running makes sense intuitively and I think it would be really disruptive (to a greater number of users) to change that behavior.

To tighten this up though, after user:scroll:detected we could check if the pointer is over the scroll container in the command log. If it's not, the user most like was not intending to scroll the command log. Keyboard scrolling is unlikely since the Application Under Test almost always grabs keyboard focus.

So we could skip temporarilyDisableAutoScrolling using that or some similar rubric, and only do it when we have extra signals that the user actually triggered the scroll event.

@astone123
Copy link
Contributor

I'm closing this ticket in favor or a more broad ticket that calls for investigating this issue further. #24171 Thanks to everyone who let us know that this is an issue

@astone123 astone123 removed their assignment Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants