-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide working recommendation for contributor Node.js switching #26441
Comments
For interest, there are a variety of node-version managers which support the ( |
I have been using |
@lmiller1990 / @emilyrohrbough Is there consensus to recommend that contributors to this repo use:
(I bet that would please @shadowspawn 😃!) I can't weigh in on this at the moment since I have been using nvm on Ubuntu and nvm-windows on Windows 11. If n (n – Interactively Manage Your Node.js Versions) is considered the tool of choice for POSIX-based systems then I would migrate and submit a PR to document this. For Windows (where I am not using WSL2) I would stay with nvm-windows. But in any case I had extreme issues trying to build Cypress on Windows and I have abandoned it for that use-case, although it is perfectly good for other repos. |
Do we need to make a recommendation? I think most developers probably prefer to decide how they'd like to manage their Node.js version on their own. WDYT? We could add a list - eg "You need to use Node.js version XXX, here are some tools you can consider which will help manage the Node.js versions your machine has installed". |
If you don't want to make a specific recommendation, then my suggestion for a replacement text would be: RequirementsYou must have the following installed on your system to contribute locally:
|
I tried out n (n – Interactively Manage Your Node.js Versions) on Ubuntu and found it was better than nvm in respect to pnpm and Yarn in that I did not need to reinstall the other package managers globally after installing a new Node.js version. So I plan to use n on Ubuntu in future. (I need all three package managers (npm, pnpm and Yarn) when I'm working on cypress-io/github-action). |
|
What would you like?
I would like to be able to follow the recommendations in CONTRIBUTING: Requirements to switch Node.js.
Requirements
You must have the following installed on your system to contribute locally:
Node.js
(See the root .node-version file for minimum version requirements. You can use avn to automatically switch to the right version of Node.js for this repo.)Why is this needed?
This is convenient when contributing to multiple Cypress repositories with different Node.js requirements.
Other
The recommendation to use avn is outdated. It no longer works.
.node-version
.Suggestion
Either:
.nvmrc
which is compatible with the POSIX-shell version of nvm. See .nvmrc.Related discussion
This follows on from cypress-io/github-action#853 (comment) from @emilyrohrbough which drew my attention to this section.
The text was updated successfully, but these errors were encountered: