Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OS notification settings on Windows #26786

Closed
astone123 opened this issue May 17, 2023 · 5 comments
Closed

Fix OS notification settings on Windows #26786

astone123 opened this issue May 17, 2023 · 5 comments
Labels
stale no activity on this issue for a long period topic: in-app notifications

Comments

@astone123
Copy link
Contributor

astone123 commented May 17, 2023

There is an issue on Windows where when a user clicks the action to turn off notifications for Cypress, the Cypress app does not appear in the Windows notification settings.

Screenshot 2023-05-17 at 3 07 46 PM

This means that users cannot re-enable notifications for the Cypress app once they have been disabled at the OS level by clicking on the option above, because Cypress doesn't appear as an application that has notification settings.

Screenshot 2023-05-17 at 3 07 58 PM

I suspect that this has to do with the way that Cypress is installed. Most applications have a Windows installer that sets up shortcuts for the applications, but Cypress doesn't do this because it is launched from the command line.

There are also some issues with the notification's display that I suspect are related

  • Windows displays electron.app.Cypress which is not our appId (it is com.electron.cypress)
  • We have to specify an icon in order for the Cypress icon to appear on the notification

It's my understanding that if the app is configured correctly, Windows will show the app name as "Cypress", and will automatically show the shortcut icon on the notification without us having to specify it.

Acceptance Criteria:

  • Cypress notifications display as from "Cypress"
  • Cypress icon shows in notification without us specifying it in code
  • Cypress appears in the Windows notification settings panel, allowing users to re-enable notifications after disabling them

Related reading:

@astone123
Copy link
Contributor Author

@lmiller1990
Copy link
Contributor

This is a 3 - spend 2-3 days max, note what you learned - if we can't solve this, we will do the initial M1 without windows support and continue exploring in Q3.

@lmiller1990
Copy link
Contributor

With our recent resource reallocation, I am de-prioritizing this. We will polish linux/macos for the M1. If we get time, we can do it, but we do not have time to do it in the June 6-20 sprint.

@cypress-app-bot
Copy link
Collaborator

This issue has not had any activity in 180 days. Cypress evolves quickly and the reported behavior should be tested on the latest version of Cypress to verify the behavior is still occurring. It will be closed in 14 days if no updates are provided.

@cypress-app-bot cypress-app-bot added the stale no activity on this issue for a long period label Dec 4, 2023
@cypress-app-bot
Copy link
Collaborator

This issue has been closed due to inactivity.

@cypress-app-bot cypress-app-bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale no activity on this issue for a long period topic: in-app notifications
Projects
None yet
Development

No branches or pull requests

3 participants