-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
significant proxy regression since v13.3.2 #28734
Comments
@krishantaylor Hi, we’re especially interested in any performance regressions like described. Are you recording to the Cloud for these runs with perf issues? Could you share a link to a Test Replay exhibiting this behavior? if not recording to the Cloud, could you share information around what types of requests are slower, how many requests, maybe a snapshot of the requests in devtools? Ideally a project to run and reproduce the issue would be ideal. |
Hi @krishantaylor 👋, we just released Cypress 13.6.3 that includes a proxy performance regression fix. Could you please upgrade to the newest version to see if that helps. I am also working on addressing a couple other proxy performance issues that should be in the next release. |
Hi! We also have the same issues on our side. Here are some thoughts on our issue if it can help you:
Thanks in advance for your investigation! |
@vinassefranche Just replying with a Cloud URL of the Test Replay where you see the 2 sec slowdown in this issue. Or you can click this purple "Report an Issue" button in the top right of the Test Replay window. |
I reported the issue there. Thanks! |
@vinassefranche Thanks, we got your report and are looking into it. There is a current issue @mschile is investigating that looks like it could be the cause here. |
@mschile, v13.6.3 still sees an extra ~2s on many requests. This is happening on both REST and graphql style requests, but usually the same ones (when comparing multiple test runs). |
@krishantaylor and @vinassefranche, I've built a pre-release binary with the changes that I believe will fix this issue. If you could install it and try it out to make sure it addresses your issue that would be great. Thanks!
|
@mschile, that seems to have done it. Thanks! |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Current behavior
Something changed internally where requests that used to finish in under 100ms now take over 2s. Depending on how tests and data calls are structured, this results in a number of flaky and consistent timeouts.
Desired behavior
Requests shouldn't consistently take an additional 2s beyond the server time.
Test code to reproduce
Cannot provide, but I've narrowed it down to v13.3.2 where the regression starts. Requests still complete as expected through v13.3.1.
Cypress Version
13.6.2
Node version
v18.19.0
Operating System
macOS 14.2.1
Debug Logs
No response
Other
No response
The text was updated successfully, but these errors were encountered: