Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

significant proxy regression since v13.3.2 #28734

Closed
krishantaylor opened this issue Jan 16, 2024 · 10 comments · Fixed by #28751
Closed

significant proxy regression since v13.3.2 #28734

krishantaylor opened this issue Jan 16, 2024 · 10 comments · Fixed by #28751

Comments

@krishantaylor
Copy link

Current behavior

Something changed internally where requests that used to finish in under 100ms now take over 2s. Depending on how tests and data calls are structured, this results in a number of flaky and consistent timeouts.

Desired behavior

Requests shouldn't consistently take an additional 2s beyond the server time.

Test code to reproduce

Cannot provide, but I've narrowed it down to v13.3.2 where the regression starts. Requests still complete as expected through v13.3.1.

Cypress Version

13.6.2

Node version

v18.19.0

Operating System

macOS 14.2.1

Debug Logs

No response

Other

No response

@krishantaylor krishantaylor changed the title significant proxy regression since v13.3. significant proxy regression since v13.3.2 Jan 16, 2024
@jennifer-shehane
Copy link
Member

@krishantaylor Hi, we’re especially interested in any performance regressions like described. Are you recording to the Cloud for these runs with perf issues? Could you share a link to a Test Replay exhibiting this behavior?

if not recording to the Cloud, could you share information around what types of requests are slower, how many requests, maybe a snapshot of the requests in devtools? Ideally a project to run and reproduce the issue would be ideal.

@jennifer-shehane jennifer-shehane added the stage: needs information Not enough info to reproduce the issue label Jan 16, 2024
@mschile
Copy link
Contributor

mschile commented Jan 17, 2024

Hi @krishantaylor 👋, we just released Cypress 13.6.3 that includes a proxy performance regression fix. Could you please upgrade to the newest version to see if that helps. I am also working on addressing a couple other proxy performance issues that should be in the next release.

@vinassefranche
Copy link

Hi! We also have the same issues on our side. Here are some thoughts on our issue if it can help you:

  • From what I've seen the issue occurred on our side when updating to 13.6.0. and every patch version of 13.6 has the same issue, including 13.6.3. I'm currently reverting this last version because of flakiness
  • We are using graphql and I can see that the first calls take a normal amount of time. Starting from some random moment, all the graphql requests take 2s. It's mostly causing flaky tests and not consistent failures which makes me thing that the issue does not occur every time
  • We are recording in the cloud so I have some replays available when I go to our cypress account. How can I tell you where to look?

Thanks in advance for your investigation!

@jennifer-shehane
Copy link
Member

@vinassefranche Just replying with a Cloud URL of the Test Replay where you see the 2 sec slowdown in this issue. Or you can click this purple "Report an Issue" button in the top right of the Test Replay window.

Screen Shot 2024-01-17 at 9 27 20 AM

@vinassefranche
Copy link

I reported the issue there. Thanks!

@jennifer-shehane
Copy link
Member

@vinassefranche Thanks, we got your report and are looking into it. There is a current issue @mschile is investigating that looks like it could be the cause here.

@jennifer-shehane jennifer-shehane added Test Replay stage: investigating Someone from Cypress is looking into this labels Jan 17, 2024
@krishantaylor
Copy link
Author

@mschile, v13.6.3 still sees an extra ~2s on many requests. This is happening on both REST and graphql style requests, but usually the same ones (when comparing multiple test runs).

@mschile
Copy link
Contributor

mschile commented Jan 19, 2024

@krishantaylor and @vinassefranche, I've built a pre-release binary with the changes that I believe will fix this issue. If you could install it and try it out to make sure it addresses your issue that would be great. Thanks!

npm install https://cdn.cypress.io/beta/npm/13.6.4/linux-x64/mschile/protocol/proxy_correlation-6d6d1241213dd6c2c93f34fd94c5fe3c02e76b2f/cypress.tgz --save-dev

@krishantaylor
Copy link
Author

@mschile, that seems to have done it. Thanks!

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 30, 2024

Released in 13.6.4.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.6.4, please open a new issue.

@cypress-bot cypress-bot bot removed stage: needs information Not enough info to reproduce the issue stage: investigating Someone from Cypress is looking into this labels Jan 30, 2024
@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants