Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trigger('mousemove', ...) yields undefined values for screenX and screenY in event handler #3187

Closed
fr0 opened this issue Jan 22, 2019 · 3 comments · Fixed by #3030
Closed

trigger('mousemove', ...) yields undefined values for screenX and screenY in event handler #3187

fr0 opened this issue Jan 22, 2019 · 3 comments · Fixed by #3030
Assignees
@kuceb
Labels
type: bug

Comments

@fr0
Copy link

fr0 commented Jan 22, 2019

Current behavior:

Triggering mousemove via .trigger correctly fills in pageX, pageY, clientX, and clientY. However, Cypress fails to fill in the screenX and screenY values.
This can cause erroneous behavior if the application depends on them.

Desired behavior:

screenX and screenY should probably just have the same values as clientX and clientY.

Versions

3.1.4
@kuceb
Copy link
Contributor

kuceb commented Jan 22, 2019

@fr0 thanks for pointing this out, I'll put it in the mix for synthetic mouse fixes

@kuceb kuceb self-assigned this Jan 22, 2019
@kuceb kuceb mentioned this issue Jan 22, 2019
Closed
@kuceb kuceb mentioned this issue Jul 19, 2019
Merged
28 tasks
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: work in progress and removed stage: work in progress stage: needs review The PR code is done & tested, needs review labels Aug 8, 2019
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Sep 6, 2019
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: needs review The PR code is done & tested, needs review stage: work in progress labels Sep 25, 2019
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Oct 7, 2019
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Oct 11, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 11, 2019

The code for this is done in cypress-io/cypress#3030, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 23, 2019

Released in 3.5.0.

@snyk-bot snyk-bot mentioned this issue Nov 1, 2019
Merged
@snyk-bot snyk-bot mentioned this issue Nov 9, 2019
Closed
@cypress-io cypress-io locked as resolved and limited conversation to collaborators Jan 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kuceb kuceb

Labels
type: bug
Projects
None yet
Milestone
No milestone
3 participants
@fr0 @jennifer-shehane @kuceb