Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap scenario and step names in UI #3947

Closed
pburkindine opened this issue Apr 11, 2019 · 10 comments · Fixed by #4428
Closed

Wrap scenario and step names in UI #3947

pburkindine opened this issue Apr 11, 2019 · 10 comments · Fixed by #4428
Labels
good first issue Good for newcomers pkg/reporter This is due to an issue in the packages/reporter directory type: user experience Improvements needed for UX

Comments

@pburkindine
Copy link

pburkindine commented Apr 11, 2019

Current behavior:

Scenario and step names are truncated with an ellipsis in the UI, making it difficult to tell at a glance what is failing and not.

Desired behavior:

Names should wrap to the next line.

@pburkindine
Copy link
Author

SS 2019-04-11 at 6 52 23 PM

@cypress-bot cypress-bot bot added the stage: proposal 💡 No work has been done of this issue label Apr 18, 2019
@jennifer-shehane jennifer-shehane added pkg/reporter This is due to an issue in the packages/reporter directory type: user experience Improvements needed for UX labels Apr 18, 2019
@cypress-bot cypress-bot bot added stage: ready for work The issue is reproducible and in scope and removed stage: proposal 💡 No work has been done of this issue labels Apr 18, 2019
@jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane added the good first issue Good for newcomers label Apr 18, 2019
@coderwurst
Copy link
Contributor

Hi! Am I understanding this correctly, that the following is the desired effect:�

image

@coderwurst
Copy link
Contributor

cool - I'm on it https://github.com/coderwurst/cypress/tree/issue-3947

I haven't managed to get the tests fully up and running locally to ensure there are no unwanted effects with very long error names, I'll get some time at the weekend to get another look!

@brian-mann
Copy link
Member

@bkucera @chrisbreiding @flotwig @bahmutov what are your thoughts on this?

@chrisbreiding
Copy link
Contributor

Looks good to me. Here's a screenshot of it in action:

Screen Shot 2019-06-12 at 1 26 41 PM

@cypress-bot cypress-bot bot added stage: work in progress and removed stage: ready for work The issue is reproducible and in scope labels Jun 12, 2019
@kuceb
Copy link
Contributor

kuceb commented Jun 12, 2019

I like it, but maybe we could hide title names at a certain minimal width, so you dont get the:

✔️
d
i
s
p
l
a
y
s

e
m
p
t
y

e

@coderwurst
Copy link
Contributor

@bkucera just the title names and leave the ticks visible?

Alternative Idea - could we set the area to have a mid-width of x pixels, so that single words are still readable?

@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Jun 19, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 19, 2019

The code for this is done in cypress-io/cypress#4428, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Jun 19, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 27, 2019

Released in 3.3.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers pkg/reporter This is due to an issue in the packages/reporter directory type: user experience Improvements needed for UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants