Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOM snapshot inspection mode does not reset when reloading file on change #4008

Closed
bahmutov opened this issue Apr 20, 2019 · 1 comment
Closed

DOM snapshot inspection mode does not reset when reloading file on change #4008

bahmutov opened this issue Apr 20, 2019 · 1 comment
Labels
type: duplicate This issue or pull request already exists

Comments

@bahmutov
Copy link
Contributor

It is very hard to reproduce this bug, but I have seen it a couple of times

v3.2.0 on Mac

  • have a test
  • when it finishes hover over a test command that changes the DOM to get "before and after" DOM snapshot animation
  • while the animation is going, change the spec, causing to test to reload and restart (I was using it.only in this case)
  • notice in the video below how the test runner did not clear the DOM snapshot animation, and eventually failed because the DOM never updated with the new contents

test-does-not-reset-dom-snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jennifer-shehane @bahmutov