-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update browser types, adding channel and making names consistent #6243
Labels
pkg/launcher
This is due to an issue in the packages/launcher directory
topic: cross browser
type: breaking change
Requires a new major release version
Comments
flotwig
added
pkg/launcher
This is due to an issue in the packages/launcher directory
type: breaking change
Requires a new major release version
labels
Jan 24, 2020
cypress-bot
bot
added
the
stage: ready for work
The issue is reproducible and in scope
label
Jan 24, 2020
cypress-bot
bot
added
stage: work in progress
and removed
stage: ready for work
The issue is reproducible and in scope
labels
Jan 27, 2020
As part of this, the logic for selecting browsers to be launched will be updated.
|
cypress-bot
bot
added
stage: needs review
The PR code is done & tested, needs review
stage: pending release
and removed
stage: work in progress
stage: needs review
The PR code is done & tested, needs review
labels
Jan 31, 2020
The code for this is done in cypress-io/cypress#6254, but has yet to be released. |
Weird, GitHub didn't pick up on the "closes" from the PR... |
Released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
pkg/launcher
This is due to an issue in the packages/launcher directory
topic: cross browser
type: breaking change
Requires a new major release version
Current behavior:
Browsers are defined like this:
...which isn't well-suited to filtering out browsers based on behavior.
Desired behavior:
Browsers are defined like this:
So this:
cypress/packages/launcher/lib/browsers.ts
Lines 8 to 60 in c15e8e1
Would become this:
Microsoft Edge #5433 would look like this:
electron
would it's family be set tochromium
, and existing code will be updated to assert on name. Since it needs to be treated differently from normal Chromium-based browsers, butisChromiumBased
would still be true.This has the advantage of making filtering easy to do:
The text was updated successfully, but these errors were encountered: