Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect Edge browser when using other install methods outside of Program Files. #6361

Closed
MehranShafqat opened this issue Feb 7, 2020 · 8 comments

Comments

@MehranShafqat
Copy link

MehranShafqat commented Feb 7, 2020

I just install cypress v4.0.0 cross browsers test run like Edge and Firefox. But in cypress dashboard im not able to see any other browser. Only chrome and electron browsers.

How can I setup other browser? cypress will not detect other browsers automatically ?

Edge and firefox browsers already installed.

FireFiox installed path: C:\Program Files\Mozilla Firefox
Edge installed path: C:\Windows\SystemApps\Microsoft.MicrosoftEdge_8wekyb3d8bbwe

Screenshot_4

Cypress version 4.0.0
OS : Windows 10

@jennifer-shehane jennifer-shehane added browser: edge browser: firefox OS: windows stage: needs investigating Someone from Cypress needs to look at this v4.0.0 🐛 Issue present since 4.0.0 labels Feb 7, 2020
@natkrish
Copy link

natkrish commented Feb 7, 2020

@MehranShafqat - You need to install FF 32 bit version and not 64 bit. ATM cypress 4 supports only 32bit. Please download 32 bit and cypress will definitely pick up. Also, try to install the latest edge version and it will also work fine.
image

@wo-ist-henry
Copy link

wo-ist-henry commented Feb 7, 2020

I had the same Issue, after I moved the Firefox installation to C:\Program Files (x86) it showed up in the Cypress Window.
But it won't run any Test, it fails with Uncaught SyntaxError: invalid regexp group.
Maybe this is a useful tip for further invastigation.

Cypress

The Hint from @natkrish didn't worked for me.

@ghiscoding
Copy link

@wo-ist-henry
Just to point out that Firefox doesn't support Regex Lookbehind, there's an open issue for the Firefox browser while Lookbehind are supported in Chrome since version 62 and you can also see this SO question for more info. You can also see in the EcmaScript Kangax table that Firefox still doesn't support it even though Chrome supports it since 2018 I think.

So you might want to check your code base (or Cypress tests) for any possible Regex Lookbehind, I had these kind of issues in a library that I made which is why your error is similar to what I had to debug myself..

Also from TC39 Proposal

Positive lookbehind assertions are denoted as (?<=...) ... Negative lookbehind assertions are denoted as (?<!...)

So perhaps do a solution search in your code base..

@flotwig
Copy link
Contributor

flotwig commented Feb 7, 2020

Closing this since it appears to be a duplicate of #6355.

@flotwig flotwig closed this as completed Feb 7, 2020
@flotwig flotwig added the type: duplicate This issue or pull request already exists label Feb 7, 2020
@MehranShafqat
Copy link
Author

@natkrish well Edge is already installed by default in windows 10 but why cypress not able to detect it ? we have to install it again from exe ?

@flotwig
Copy link
Contributor

flotwig commented Feb 9, 2020

@MehranShafqat currently Edge is only detected if installed in Program Files. I'll reopen this so we can add detection for other install methods.

@flotwig flotwig reopened this Feb 9, 2020
@jennifer-shehane jennifer-shehane removed the type: duplicate This issue or pull request already exists label Feb 10, 2020
@jennifer-shehane jennifer-shehane changed the title Cypress how detect other browsers Detect Edge browser when using other install methods outside of Program Files. Feb 10, 2020
@jennifer-shehane
Copy link
Member

Make sure to update to 4.0.1 to see what browsers are detected now as we improved some of the detection.

@jennifer-shehane
Copy link
Member

Closing as resolved.

If you're experiencing a bug similar to this in Cypress, please open a new issue with a fully reproducible example that we can run. There may be a specific edge case with the issue that we need more detail to fix.

@jennifer-shehane jennifer-shehane removed the stage: needs investigating Someone from Cypress needs to look at this label Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants