chore: fix problem with single tab run mode introduced by #27786 #28032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cacieprins
approved these changes
Oct 11, 2023
ryanthemanuel
commented
Oct 11, 2023
chrisbreiding
approved these changes
Oct 11, 2023
16 flaky tests on run #51580 ↗︎
Details:
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > automatically parses application/json request bodies |
Output
|
|
| network stubbing > waiting and aliasing > can spy on a 304 not modified image response |
Output
|
|
e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| cy.origin- Cypress.config() > serializable > overwrites different values in secondary, even if the Cypress.config() value does not exist in the primary |
Output
|
|
e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| cy.origin assertions > #consoleProps > .should() and .and() |
Output
|
|
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| ... > correctly returns currentRetry |
Output
|
|
| ... > correctly returns currentRetry |
Output
|
|
| ... > correctly returns currentRetry |
Output
|
|
cy/timers.cy.js • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| driver/src/cy/timers > delays calls to requestAnimationFrame when paused |
Test Replay
Output
|
|
The first 5 flaky specs are shown, see all 9 specs in Cypress Cloud.
Review all test suite changes for PR #28032 ↗︎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
#27786 (which hasn't been released yet) inadvertently exposed an issue with single tab run mode where we weren't properly flagging an expected closure for electron. We fix this by ensuring to close the tab in an expected fashion on the last spec even when we are in single tab run mode.
Steps to test
Run tests in
@cypress/reactin electronHow has the user experience changed?
n/a
PR Tasks
cypress-documentation?type definitions?