Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: convert config .eslintrc.json to .js #199

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

MikeMcC399
Copy link
Collaborator

Issue

ESLint 8.x configuration files in JSON format become deprecated in ESLint 9.x which only uses JavaScript format.

Change

The .eslintrc.json ESLint configuration file is converted to .eslintrc.js (JavaScript). (Note that this does not convert to a "flat config" format, which is left for a later migration stage.)

This is one building block contributing to a migration from ESLint 8.x to ESLint 9.x.

Verification

On Ubuntu 22.04.4 LTS, Node.js 20.12.2 LTS

npm ci
npm run lint

References

ESLint 8.x

ESLint 9.x

@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 marked this pull request as ready for review April 30, 2024 14:15
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jennifer-shehane jennifer-shehane merged commit a8e36f7 into cypress-io:master Apr 30, 2024
8 checks passed
@MikeMcC399 MikeMcC399 deleted the config-to-js branch April 30, 2024 15:24
@cypress-app-bot
Copy link

🎉 This PR is included in version 3.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants