tests: save legacy tests

[MikeMcC399]

Situation

Tests in the tests/lib/rules which run internally under ESLint 7.x and 8.x are not compatible with ESLint 9.x.

The guide Migrate to 9.0 > FlatRuleTester is now RuleTester explains:

As announced in our blog post, the temporary FlatRuleTester class has been renamed to RuleTester, while the RuleTester class from v8.x has been removed. Additionally, the FlatRuleTester export from eslint/use-at-your-own-risk has been removed.

This is a breaking change for the tests.

Goal

The enhancement goal is to be able to test the repo rules using each of the supported versions of ESLint: 7.x, 8.x and 9.x.

Migration steps

Achieving the goal requires separating the tests into a legacy copy, for use with the RuleTester class of ESLint 7.x and 8.x, and another copy which will be migrated to use the RuleTester of ESLint 9.x.

The migration is done in two steps:

1. Create the legacy copy of tests, a script to use this copy and a modification to the CircleCI workflow.
2. Modify the current copy of tests for compatibility with the new RuleTester class in ESLint 9.x.

Changes

This PR deals with creating the legacy copy.

A follow-on PR will take care of the second step of migrating tests to run under to ESLint 9.x.

1. Copy tests to tests-legacy
2. Create a jest.config-legacy.js
3. Create a test:legacy script
4. Modify circle.yml to test ESLint 7 and 8 with test-legacy

Note that the original tests/lib/rules directory is temporarily unused in this PR.

References

• Testing rules with flat config and the RuleTester class
• FlatRuleTester is now RuleTester
• v9 > RuleTester

Verification

Ubuntu 22.04.4 LTS, Node.js v20.12.2 LTS and on
Windows 11, Node.js v20.12.2

npm ci
npm install eslint@7 --force
npm run test:legacy
npm install eslint@8
npm run test:legacy

At this point, ESLint 9 cannot be tested and would result in multiple errors. The resolution is left for a follow-on PR.

[cypress-app-bot]

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.

[jennifer-shehane]

@MikeMcC399 I'm not sure how the new tester works, but if possible, it seems like there'd be utility to breaking out these rules so that they can be in a shared file used for both legacy and recent tests. Just thinking how manual it will be to update both sets of tests whenever an update it needed. Not really sure it's worth it though for just 2 files.

[MikeMcC399]

@jennifer-shehane

This is similar to the Cypress migration from 9.x to 10.x where it was necessary in Cypress GitHub Actions to have two sets of tests in parallel for a limited time, one set for Cypress 9.x that was only updated as absolutely necessary and a new set of tests for Cypress 10.x which were maintained and updated. At some stage, a new major version was declared and support for Cypress 9.x was dropped.

It will be difficult to continue to support ESLint 7, 8 and 9 all in one version of this plugin and at some stage support for earlier versions will need to be dropped. I will put this is a separate issue for discussion.

Thanks for your comments!

[cypress-app-bot]

🎉 This PR is included in version 3.3.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀