Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update .node-version to 22.11.0 #245

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

MikeMcC399
Copy link
Collaborator

Issue

The following Node.js version files are currently set to 20.12.2

These are not currently used in any workflow or referred to elsewhere. They are provided as a convenience to contributors using Node.js managers (like n or nvm) that can automatically switch Node.js versions based on the file contents.

Nevertheless, for consistency, the Node.js version should be aligned to CI usage in circle.yml where the CircleCI Docker image cimg/node:22.11.0 is currently being used (see PR #243).

Change

Update the following files to Node.js 22.11.0 to match the Node.js version used by the circle.yml workflow with the CircleCI Docker image cimg/node:22.11.0:

Verification

On Ubuntu 24.04.1 LTS with n installed

git clone https://github.com/cypress-io/eslint-plugin-cypress
cd eslint-plugin-cypress
n auto
node -v
npm ci
npm test
npm run lint

Confirm that Node.js v22.11.0 is used and that all tests and linting pass.

update .nvmrc to 22.11.0 also
@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 marked this pull request as ready for review November 6, 2024 12:45
@jennifer-shehane jennifer-shehane merged commit 19842d3 into cypress-io:master Nov 6, 2024
8 checks passed
@MikeMcC399 MikeMcC399 deleted the update/node-version branch November 6, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants