Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove oauth due to security vulnerability #6

Merged
merged 1 commit into from
Aug 19, 2021
Merged

fix: Remove oauth due to security vulnerability #6

merged 1 commit into from
Aug 19, 2021

Conversation

TayHobbs
Copy link

PR Checklist:

  • I have run npm test locally and all tests are passing.
  • I have added/updated tests for any new behavior.
  • If this is a significant change, an issue has already been created where the problem / solution was discussed: CWE-310 - use of SHA1 in oauth.js #3

PR Description

Closes #3

flotwig
flotwig approved these changes Aug 19, 2021
View reviewed changes
Copy link

@flotwig flotwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass locally. Clear to merge since this is unneeded in cy.

@flotwig flotwig changed the title Remove oauth due to security vulnerability fix: Remove oauth due to security vulnerability Aug 19, 2021
@flotwig flotwig merged commit 9034d3a into cypress-io:master Aug 19, 2021
@flotwig
Copy link

flotwig commented Aug 19, 2021

🎉 This PR is included in version 2.88.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flotwig flotwig flotwig approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CWE-310 - use of SHA1 in oauth.js
2 participants
@TayHobbs @flotwig