Putting Corefreqd in the root cgroup

[gel-crabs]

Hey, I noticed in the troubleshooting section it is recommended to put corefreqd in the root cgroup; I did a lot of research finding out how to do this with systemd, and I found out how; in corefreqd.service, under [Service], put Slice=-.slice, like so:

# CoreFreq
# Copyright (C) 2015-2022 CYRIL COURTIAT
# Licenses: GPL2

[Unit]
Description=CoreFreq Daemon

[Service]
Type=simple
ExecStart=corefreqd -q
ExecStop=/bin/kill -QUIT $MAINPID
RemainAfterExit=no
SuccessExitStatus=SIGQUIT SIGUSR1 SIGTERM
Slice=-.slice

[Install]
WantedBy=multi-user.target

systemd-cgls then shows it under the root cgroup after rebooting. Is this something that should be added to the service file?

[cyring]

Nice, thanks for the tip.

For your testings, it is now available in the develop branch at commit 0e95b11

[gel-crabs]

Just did a couple geekbenches, performance has increased

Without cgroup modification: https://browser.geekbench.com/v5/cpu/19224299
With cgroup modification: https://browser.geekbench.com/v5/cpu/19224374

[gel-crabs]

Does corefreqd change the P-states, idle states, etc. or is it just the kernel module that does that?

[cyring]

P-states and C-states are changed if manually requested/selected from the UI.
They can however be initialized with a few features, like:

• activating Turbo with Intel NEHALEM
• registering CPU-Idle
• activating Intel HWP or AMD CPPC

I suggest you show me corefreq-cli outputs before/after increasing performance.

[gel-crabs]

What command would you like me to run to get the needed output?

[cyring]

What command would you like me to run to get the needed output?

Does corefreqd change the P-states, idle states, etc. or is it just the kernel module that does that?

Forget the claimed outputs because I guarantee nothing, unless a bug, is touched against performance.
Regards

[gel-crabs]

That's fair, I've since gathered that Geekbench scores tend to vary quite a bit anyway