Change how we are pulling the maxmind db (#1190)

Update the way we are pulling in the maxmind db on intialization and set fallback if the file doesnt download.

Author: andrewmcodes

Gemfile.lock

@@ -697,7 +697,7 @@ DEPENDENCIES
   webpacker (~> 5.0.1)
 
 RUBY VERSION
-   ruby 2.6.5p114
+   ruby 2.6.6p146
 
 BUNDLED WITH
    2.1.4

app/jobs/download_and_extract_maxmind_file_job.rb

@@ -4,9 +4,11 @@
 require "rubygems/package"
 
 class DownloadAndExtractMaxmindFileJob < ApplicationJob
-  MAXMIND_URI = URI("http://geolite.maxmind.com/download/geoip/database/GeoLite2-City.tar.gz")
-  MAXMIND_DIR = Rails.root.join("db/maxmind")
+  MAXMIND_URI = URI("https://download.maxmind.com/app/geoip_download?edition_id=GeoLite2-City&license_key=#{ENV["MAXMIND_LICENSE_KEY"]}&suffix=tar.gz")
+  MAXMIND_DIR = Rails.root.join("tmp/maxmind")
   MAXMIND_PATH = MAXMIND_DIR.join("GeoLite2-City.tar.gz")
+  MAXMIND_LEGACY_DIR = Rails.root.join("db/maxmind")
+  MAXMIND_LEGACY_PATH = MAXMIND_LEGACY_DIR.join("GeoLite2-City.tar.gz")
 
   queue_as :low
 
@@ -21,14 +23,20 @@ def perform
 
   def download
     FileUtils.rm_f MAXMIND_PATH
+
     File.open MAXMIND_PATH, "wb" do |file|
       Net::HTTP.start(MAXMIND_URI.host) do |http|
         http.open_timeout = 1
         http.read_timeout = 1
-        http.request_get(MAXMIND_URI.path) do |response|
+        http.request_get(MAXMIND_URI) do |response|
+          throw :abort if response.body.empty?
           response.read_body { |segment| file.write segment }
         end
       end
+    rescue => e
+      FileUtils.rm_f MAXMIND_PATH
+      FileUtils.cp MAXMIND_LEGACY_PATH, MAXMIND_PATH
+      logger.error "Error downloading maxmind file! #{e.message}"
     end
   end
 

config/initializers/maxmind.rb

@@ -1 +1,5 @@
-DownloadAndExtractMaxmindFileJob.new.extract
+if Rails.env.production? || ENV["CI"] == "true"
+  DownloadAndExtractMaxmindFileJob.perform_now
+else
+  DownloadAndExtractMaxmindFileJob.perform_later
+end

test/jobs/download_and_extract_maxmind_files_job_test.rb

@@ -0,0 +1,8 @@
+require "test_helper"
+
+class DownloadAndExtractMaxmindFilesJobTest < ActiveJob::TestCase
+  test "download" do
+    stub_request(:get, /download\.maxmind\.com/).to_return(status: 200)
+    DownloadAndExtractMaxmindFileJob.perform_now
+  end
+end