Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronized signals for NIDaq #127

Open
AhmetCanSolak opened this issue Sep 29, 2022 · 2 comments
Open

Synchronized signals for NIDaq #127

AhmetCanSolak opened this issue Sep 29, 2022 · 2 comments
Labels
feature request New feature or request good first issue Good for newcomers hardware help wanted Extra attention is needed

Comments

@AhmetCanSolak
Copy link
Contributor

FEATURE: Synchronized signals for NIDaq

Is your feature request related to a problem? Please describe.

We need an abstraction that allows us to synchronize certain signals with NIDaq Timelapse (see #110 ). This is crucial for timelapse execution for each instrument that we have in-house and for our users. This is typically implemented with tasks, triggers and counters in nidaqmx API (see https://nidaqmx-python.readthedocs.io/en/latest/). We used to do this also with legacy_nidaq implementation.

Describe the solution you'd like

The solution I imagine is having an internal abstraction within NIDaq Timelapse class where such synchronizing points can be defined and assigned to different channels. In case there are multiple such abstractions defined we can ask NIDaq class to execute them in-order loop. I can imagine this might require doing certain checks internally to make sure each channel can provide correct amount of samples for given sampling rate. Happy to take other ideas both here and on the PR before finalizing the concept implementation.

@AhmetCanSolak AhmetCanSolak added feature request New feature or request good first issue Good for newcomers help wanted Extra attention is needed hardware labels Sep 29, 2022
@YangLiujames
Copy link
Contributor

I can take this task

@AhmetCanSolak
Copy link
Contributor Author

Sure @jamesliu1990, maybe you can finish #128 first and then tackle this. This might also give time for #126 to be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request good first issue Good for newcomers hardware help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants