Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow automatic start of builds after pull request has been opened #11

Closed
mdio opened this issue Apr 30, 2015 · 5 comments · Fixed by #21
Closed

Allow automatic start of builds after pull request has been opened #11

mdio opened this issue Apr 30, 2015 · 5 comments · Fixed by #21
Assignees

Comments

@mdio
Copy link
Contributor

mdio commented Apr 30, 2015

Hi, Honza.
You probably already anticipated it, so here's the request for the possibility to remove the "lttm barrier". :)

We're using your awesome tool for our pull requests which go to private repositories with only trusted users to access them.
Forgetting to type lttm leads to no hints at all of any failed tests.

Right now we simply return isEnabled: true from isBotEnabled() in our own build of Buildasaur but it would be nice if you could incorporate that as an option so we won't have to modify your code after each update.

@czechboy0
Copy link
Member

Hey Michael,

thanks for filing the first Buildasaur issue! :) Yeah making the lttm barrier optional makes sense, I'll look into allowing for customization of the bot enabled state from the UI or from a config file. Let me know if you have any more issues/ideas!

@mdio
Copy link
Contributor Author

mdio commented Apr 30, 2015

Not our use case but others may benifit from the possibility to set this individually per repository (see my other issue about multi repo support ;).

@czechboy0
Copy link
Member

Yeah it would definitely be configurable on a per-Syncer basis.

@czechboy0
Copy link
Member

Hey Michael,

optional lttm is in, checkout the latest release: https://github.com/czechboy0/Buildasaur/releases/tag/v0.2.5

You should now be able to just download the .app from the release page and use that. In the UI is now a switch where you can disable the "lttm" barrier - thanks for that name, by the way :)

Let me know if this works for your team and keep the ideas coming!

@mdio
Copy link
Contributor Author

mdio commented May 4, 2015

The switch to disable the lttm barrier works very good.
Thanks for that!

Regarding ideas... well besides the mutli repo support we have everything we need right now.
You could have a look at the GitHub Pull Request Builder Plugin (which we used before moving to Swift and Xcode Server) and draw some ideas from that if you haven't already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants