Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you put bots or at least triggers under source control? #145

Closed
alimoeeny opened this issue Sep 30, 2015 · 8 comments
Closed

Can you put bots or at least triggers under source control? #145

alimoeeny opened this issue Sep 30, 2015 · 8 comments

Comments

@alimoeeny
Copy link

I think it is reasonable to share triggers (or even bots?) under source control and / or share them with team members. Specially if you have a people in different locations with their own network ...

@czechboy0
Copy link
Member

Yes, great idea, this is actually something I've been considering for a while. I built a Ruby tool xcskarel which can actually dump Bot config into a file (designed for this purpose).

Let me know what exact workflow would be appropriate for you, there are many ways we could go about this.

@alimoeeny
Copy link
Author

Thanks @czechboy0 , greatly appreciate your swift :) response.
I guess this overlaps with #1
This is how I imagine it may work:
I create a bot and I want to share it with the rest of the team so that they can run their local bots, experiment with it, and when we change it we want to be able to keep track of changes and review the changes ....
I have experience with TravisCI and drone.io and similar CI systems, but very new to XCServer and Buildasuar (awesome name by the way, I pronounce it buildozer btw).
let me look into your xcskarel to see how it works first.

@czechboy0
Copy link
Member

Thanks @alimoeeny, that sounds great. Buildasaur saves its preferences to ~/Library/Application Support/Buildasaur - would you want to add those into source control?

@alimoeeny
Copy link
Author

Dude, you save my server password and my ssh passpharse and github token in plain text in ServerConfig.json and Projects.json . This is totally unacceptable.
Can we do keychain?
Do you want me to send a PR for this?

And yes, I think Having Build templates under source control would be enough. Thanks.

@czechboy0
Copy link
Member

There is a ticket for this already: #137. Feel free to contribute if you really need it ASAP :) (just mark it in the ticket if you do, @Brett-Best was planning on implementing that, so let's make sure you guys don't duplicate your work).

@alimoeeny
Copy link
Author

Thanks, I'll wait for @Brett-Best

@czechboy0
Copy link
Member

Cool 👍

@Brett-Best
Copy link
Contributor

@alimoeeny I am hoping to have this done in the next week or so, feel free to submit a PR before that time though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants