Incorrect comment info

[valeriomazzeo]

When manually triggering an integration on the pull requests bot (no code changes between the first integration and the manual one being triggered), buildasaur post on GitHub a comment with the info about the first integration instead than about the last one.

The same happens when triggering a third integration manually.

I am almost sure this is caused by having no code changes in between those integration.

[czechboy0]

Interesting, I'll try to reproduce. It should always report the status of the last integration for the commit, but possibly there's a bug. Thanks for reporting, I'll get back once I know what's up.

[valeriomazzeo]

thanks for looking into it 👍

[czechboy0]

Hmm, it seems to work as expected to me. Every time I manually kick off an integration from Xcode, a new comment is posted on GitHub afterwards with the result of the latest integration. Each of these comments starts with Result of integration 1 then 2 and 3... And this number should go up with every new integration. I tried it here, you can see that no commits have been pushed between those comments but the last 3 always report the right integration's result (this is my sandbox repo).

Can you please provide a bit more information? How do you know the result is stale? Does Buildasaur post multiple comments starting with the same number in Result of integration NUMBER? Can you maybe provide a screenshot or any piece of log? Thanks!

[valeriomazzeo]

This is what happened:

In that bot the first integration, well you can see the results: the simulator timed out.
The second one was actually ok, but buildasaur kept printing the result of the first.

[czechboy0]

I don't suppose you still have those integrations on your server and could send me a JSON to test with? 😦 This looks like a bug, but it's very weird that it is happening. I can't reproduce it or see in code how this could happen other than by deleting the previous integration/bot on the server. This definitely should not happen when relaunching an integration on the same code.

[valeriomazzeo]

Buildasaur deleted the integration for that PR so the answer is no :(

Unless there is a log on buildasaur that can be helpful to you?

[czechboy0]

Buildasaur should only delete Bots (the build job description, is tied to one branch). And it starts an Integration (one run of the build job, which has a result and a number).

Let me know if you can think of a way to reproduce it. I'd really like to track this one down. Thanks!

[valeriomazzeo]

Sorry, I didn't word it correctly. It deleted the bot.

Just to make sure, in case it happens again what log file would be useful to you?

[czechboy0]

Hmm in case you still have it, getting the output from https://XCODE_SERVER_IP:20343/api/integrations would be most useful, followed by the log file in ~/Library/Application Support/Buildasaur/Builda.log

[czechboy0]

@valeriomazzeo Sorry, I can't reproduce it. If this ever happens again, feel free to comment and provide some logs or any more details and I'll reopen this issue.

[valeriomazzeo]

sure, no problem 👍

to be honest it's not happening all the time, but as long as I spot it I will provide some logs :)