Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep links into Xcode from GitHub comments #176

Merged
merged 3 commits into from
Oct 14, 2015
Merged

Conversation

czechboy0
Copy link
Member

Fixes #160.

However, the solution wasn't straightforward. The deep links into Xcode are in a format of xcbot://mycomputer.local/...., which has a scheme of xcbot, which isn't on GitHub's whitelist - so they were getting blocked by GitHub.

However, I'm already running a tiny server called Satellite, which is used for Buildasaur build badges. So I reused it to proxy to the required urls.

So the way it works now is that the links here on GitHub point to Satellite - and when you click on one, Satellite immediately redirects you to the right xcbot link.

It's almost not noticable, so I just thought I'd let people know. But yeah - deep links for everyone!

Currently, they show up in two places:

  • the build status icons are now clickable
  • the build status comments posted by Buildasaur now have the "Integration X" part hyperlinked

Let me know if this works for you.

@buildasaur
Copy link
Collaborator

Result of Integration 1

Duration: 4 minutes and 6 seconds
Result: 8 errors, failing state: build-errors

@buildasaur
Copy link
Collaborator

Result of Integration 2

Duration: 2 minutes and 50 seconds
Result: All 23 tests passed, but please fix 2 warnings.
Test Coverage: 21%.

czechboy0 added a commit that referenced this pull request Oct 14, 2015
Deep links into Xcode from GitHub comments
@czechboy0 czechboy0 merged commit 1fd3edf into master Oct 14, 2015
@czechboy0 czechboy0 deleted the hd/xcode_deep_links branch October 14, 2015 20:59
@KrauseFx
Copy link

Wow! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants