Initial refactor of syncer #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of integration 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #18, a refactor is necessary first. Working on isolating branches for PRs so that we can eventually sync branches with Bots instead of just PRs.
Simplified the syncer a bunch. Now instead of one god class, we spread the responsibility of each sync case to a different subclass of a
SyncPair. One is for a PR without a Bot (creates a bot), one for a Bot without a PR (deletes a bot) and one for a PR with a Bot (syncs, the most complex case). This should scale well to new cases like Branch and a Bot etc. We'll see. This should definitely be easier to read.Also responsibilities of the syncer were spread across a couple of extension files, like
SyncerBotManipulation,SyncerBotNaming(making room for #29),SyncerGitHubUtilsandSyncerBotUtils. The main syncer, theHDGitHubXCBotSynceris down to 240 lines.