Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move API calls to separate files #47

Closed
cojoj opened this issue Jun 28, 2015 · 5 comments
Closed

Move API calls to separate files #47

cojoj opened this issue Jun 28, 2015 · 5 comments

Comments

@cojoj
Copy link
Contributor

cojoj commented Jun 28, 2015

At the moment, all API calls are stored in XcodeServer.swift. It'd be advisable to move the to separate files and make extensions from them as the number of API calls may increase in the future.

I suggest separating them by type eg. XcodeServer+Bots will store all Bot related API calls, XcodeServer+Integrations will handle Integration and so on...

I don't know what's the proper naming convention and used well know convention from Objective-C. We can stick to this or decide on different style.


This issue is blocked until #44 is completed as this one may introduce some merge conflicts.

@cojoj
Copy link
Contributor Author

cojoj commented Jun 30, 2015

@czechboy0 please hold with work in XcodeServer class as I'm planning to apply proposed changes in this issue. I'll probably do it today.

It's already a pain in the ass working with XcodeServer class in #48 so it's high time to do some clean up! 😉

@czechboy0
Copy link
Member

Go for it, I don't have any outstanding work on a branch (a rare moment, use it). I was working on Buildasaur the other day, migrating that beast to Swift 2.

@czechboy0
Copy link
Member

Another one: #55.

@cojoj
Copy link
Contributor Author

cojoj commented Jul 1, 2015

Platform and Device added here: #57

@czechboy0
Copy link
Member

Finished by #58.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants