-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Xcode 7 Support #44
Conversation
This reverts commit b173a1d.
Conflicts: XcodeServerSDK.xcodeproj/project.pbxproj
…ew, safer Xcode 7 API happy when creating bots. For now I'll probably trust self signed certificates right away but it'd be nice to show similar UI like Xcode does when trusting a self-signed server cert for the first time. Also, more work on the device specification parsing/creating. Also, added a getPlatforms call, which is useful when creating DeviceSpecification filters.
- fingerprint now automatically learned during blueprint validation - added more endpoint support for validating that user can manage bots
- more sample responses - removed old comment
@@ -27,6 +27,7 @@ public class SourceControlBlueprint : XcodeServerEntity { | |||
public let privateSSHKey: String? | |||
public let publicSSHKey: String? | |||
public let sshPassphrase: String? | |||
public var certificateFingerprint: String? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since its being set to nil
on the init why not declare it with a default value?
public var certificateFingerprint: String? = nil
And only set it to something else when a value is passed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, fixed 👍
@czechboy0 I added some minor comments/questions for you. Made a big «boo boo» but left the comment there for history :p with an edit obviously :) |
Ok, pushed the initial DVR integration here, very much WIP but proof of concept is working! Especially venmo/DVR#5 will make a big difference to us, I think. Now, 😴 |
Great; I'll try to play with it tomorrow |
- added more example jsons/cassettes for tests - starting to test all this stuff added here... blah... help!?
@czechboy0 I don't want to mess within existing code, especially while you're doing something but I've spotted a thing. In XcodeServer, there's this |
@cojoj You're absolutely right. Rename it in your PR and since I haven't touched that line of code, we should be ok. |
…! yayz. that means that even the device specification woodoo is now solved. we officially support xcode 7 (mostly!) :)
Sorry, @cojoj, I had to comment out the Which, will be now. Yeah, both the new fingerprint validation and the new testing device format works. |
Adding the basics of Xcode 7 API support. This is work in progress and will have many tests be added and more features.
Most of this is based on reverse engineering how the new Xcode 7 API works. Everything is being tested live locally during development. I added more sample JSON responses as files for future parsing tests and reference.
When merged, should fix #22 and #21 and a bit of #23.
Feel free to take a look & provide feedback, @cojoj @esttorhe