Refactoring of sendRequestWithMethod
#86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changes: Move the code responsible for adding `HTTP.Method ` to params dictionary from `sendRequestWithMethod` method to `createRequest` method. - Reason: In `createRequest` method it was possible to pass `HTTP.Method` using both `method` and `params` parameter. Passing `HTTP.Method` as a `method` parameter should be enough. - Other changes: Update `testDELETERequestCreation` test
Result of Integration 1Duration: 1 minute and 10 seconds |
czechboy0
pushed a commit
that referenced
this pull request
Jul 26, 2015
Refactoring of `sendRequestWithMethod`
|
Great stuff, thanks @pmkowal! 👍 |
|
My pleasure 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the code responsible for adding
HTTP.Methodto paramsdictionary from
sendRequestWithMethodmethod tocreateRequestmethod.
In
createRequestmethod it was possible to passHTTP.Methodusingboth
methodandparamsparameter. PassingHTTP.Methodas amethodparameter should be enough.Update
testDELETERequestCreationtest