Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with channels 3 #68

Closed
OmarWKH opened this issue Nov 17, 2020 · 5 comments
Closed

Incompatible with channels 3 #68

OmarWKH opened this issue Nov 17, 2020 · 5 comments

Comments

@OmarWKH
Copy link
Collaborator

OmarWKH commented Nov 17, 2020

Related to #56.

Websocket breaks when channels 3 is installed. Channels 2.4.0 works.

@EJH2
Copy link
Collaborator

EJH2 commented Dec 12, 2020

Websocket breaking in channels v3 seems to stem from this issue. This can be fixed by adding the websocket url in routing.py as such:

urlpatterns = [
    url(r'^ws/progress/(?P<task_id>[\w-]+)/?$', consumers.ProgressConsumer.as_asgi()),
]

Now, either we can do that and drop support for channels v2, or do a try/except clause and support both. Thoughts @czue @OmarWKH?

@czue
Copy link
Owner

czue commented Dec 13, 2020

I guess if there's no major downside and it's a simple try/catch then supporting both for now seems better?

@Hapyr

This comment has been minimized.

@EJH2

This comment has been minimized.

@Hapyr

This comment has been minimized.

@OmarWKH OmarWKH closed this as completed Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants