Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the error handling #11

Closed
aloisdg opened this issue Oct 14, 2022 · 2 comments · Fixed by #14
Closed

Improve the error handling #11

aloisdg opened this issue Oct 14, 2022 · 2 comments · Fixed by #14
Assignees
@Le-Diraison-Sandrine
Labels
hacktoberfest hacktoberfest-accepted

Comments

@aloisdg
Copy link
Member

aloisdg commented Oct 14, 2022

Hello,

we use core.setFailed(error.message) to handle message but setFailed can take an error in input. It would be nice to replace it with core.setFailed(error).

Cheers
@Le-Diraison-Sandrine
Copy link
Contributor

hey on fait ça marielle et moi

Merged
@aloisdg
Copy link
Member Author

aloisdg commented Oct 14, 2022

Sure go ahead :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Le-Diraison-Sandrine Le-Diraison-Sandrine

Labels
hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: core.setFailed delete .message Le-Diraison-Sandrine/strip-markdown-html
2 participants
@aloisdg @Le-Diraison-Sandrine