Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quest/Malawi Core] Android App : Remove fetch userinfo step on login steps #31

Closed
sevenreup opened this issue Feb 29, 2024 · 5 comments · Fixed by #35
Closed

[Quest/Malawi Core] Android App : Remove fetch userinfo step on login steps #31

sevenreup opened this issue Feb 29, 2024 · 5 comments · Fixed by #35
Assignees
Labels
enhancement New feature or request

Comments

@sevenreup
Copy link

The current login steps are

flowchart LR
    Token --> UserInfo --> practitioner-details
Loading

The data retrieved from UserInfo is the same data that we can retrieve by decoding the JWT token.

practitioner-details response
UserInfo response

Proposal

Remove the UserInfo step and just decode the JWT data

@sevenreup sevenreup added the enhancement New feature or request label Feb 29, 2024
@sevenreup
Copy link
Author

@calmwalija @evance-mose @KhumboLihonga @LZRS Please look at this proposal and see if there is anything to consider

@sevenreup sevenreup self-assigned this Feb 29, 2024
@calmwalija
Copy link

@sevenreup that's a good idea, the CHWs were also complaining about how slow it is logging in, I can look into it!

@sevenreup
Copy link
Author

And another step we can take is right now.

The only time we skip sending a request to the server at login is when there is no network. But we can also just check if the auth token is still active (and verify credintials) then just proceed to login instead of fetching the practitioner-details again. This will improve the login time at places with slower internet connectivity

@LZRS
Copy link
Collaborator

LZRS commented Mar 1, 2024

Yeah, I'm also in agreement since it would essentially simplify the process of login in the app

@KhumboLihonga
Copy link

This sounds like a good enhancement. What would be the level of effort on this? @sevenreup

@calmwalija calmwalija self-assigned this Mar 6, 2024
@calmwalija calmwalija changed the title Remove fetch userinfo step on login steps [Quest/Malawi Core] Android App : Remove fetch userinfo step on login steps Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants