-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Quest/Malawi Core] Android App : Remove fetch userinfo step on login steps #31
Comments
@calmwalija @evance-mose @KhumboLihonga @LZRS Please look at this proposal and see if there is anything to consider |
@sevenreup that's a good idea, the CHWs were also complaining about how slow it is logging in, I can look into it! |
And another step we can take is right now. The only time we skip sending a request to the server at login is when there is no network. But we can also just check if the auth token is still active (and verify credintials) then just proceed to login instead of fetching the practitioner-details again. This will improve the login time at places with slower internet connectivity |
Yeah, I'm also in agreement since it would essentially simplify the process of login in the app |
This sounds like a good enhancement. What would be the level of effort on this? @sevenreup |
The current login steps are
The data retrieved from
UserInfo
is the same data that we can retrieve by decoding theJWT
token.practitioner-details response
UserInfo response
Proposal
Remove the UserInfo step and just decode the JWT data
The text was updated successfully, but these errors were encountered: