Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiPolygon clipping #20

Closed
Fil opened this issue Sep 12, 2018 · 3 comments
Closed

MultiPolygon clipping #20

Fil opened this issue Sep 12, 2018 · 3 comments

Comments

@Fil
Copy link
Member

Fil commented Sep 12, 2018 •
edited
Loading

The multipolygon branch is a first step towards #9 and #11.

There is a demo here:
https://beta.observablehq.com/d/368627e7d1bcc0cb

each polygon is processed in turn.

multipolygon clipping 1

There are still a few bugs though — as you can see if you rotate the map in the demo, there are sometimes mix-ups in the variables that control the points' visibility, resulting in dots for points that should belong to a polygon, or in full-white surfaces that should be full-black.

capture d ecran 2018-09-12 a 22 26 28

capture d ecran 2018-09-12 a 22 25 58
@Fil
Copy link
Member Author

Fil commented Sep 16, 2018

29bd5ef fixes the weird mix-ups between lines in different polygons.

@Fil
Copy link
Member Author

Fil commented Sep 16, 2018

The complete inversion that stil happens sometimes is not specific to the multipolygon branch — I have it all the same in master.

@Fil Fil closed this as completed Sep 16, 2018
@Fil
Copy link
Member Author

Fil commented Sep 16, 2018

merged #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Fil