-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pack layout should allow parent padding? (“Margin”?) #7
Comments
I’m not sure about the name “margin”; maybe it’s worth having sibling padding and parent padding? Or maybe padding should automatically apply to the parent circle, not just the siblings. |
I like the idea of having just one padding that applies to both parent and siblings. |
Seems reasonable to me, too. |
Related question: Should the padding be configurable per node? Seems like you could compute the padding per node if it is specified as a function, and it would apply to padding between that node and its children (parent-child padding), and amongst its children (sibling padding). |
Related #9. |
Yep, it would certainly be good to have it configurable per node as well. Sounds like d3/d3#2473 would be a more general solution to this. |
Fixed. |
Related d3/d3#2536; see demo.
The text was updated successfully, but these errors were encountered: