Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Platform Profile List: low-power vs quiet #161

Open
ikus060 opened this issue Jan 29, 2025 · 1 comment
Open

Incorrect Platform Profile List: low-power vs quiet #161

ikus060 opened this issue Jan 29, 2025 · 1 comment
Assignees

Comments

@ikus060
Copy link

ikus060 commented Jan 29, 2025

The list of available platform profiles on my system is incorrect. It should include "quiet", but instead, it displays "low-power", which is not available on my system.

Expected Behavior

The system should list only the profiles that are actually available, as defined in /sys/firmware/acpi/platform_profile_choices.

Actual Behavior

The system incorrectly shows "low-power" as an option, even though it is not listed in /sys/firmware/acpi/platform_profile_choices.

+++ Platform Profile
/sys/firmware/acpi/platform_profile                    = balanced
/sys/firmware/acpi/platform_profile_choices            = quiet balanced performance

Image

Suggested Fix

From a quick review of the code, it seems that the list of available profiles should be retrieved dynamically from /sys/firmware/acpi/platform_profile_choices, rather than using a predefined list of values. This would ensure that only valid options are presented to the user.

@d4nj1 d4nj1 self-assigned this Feb 19, 2025
@d4nj1
Copy link
Owner

d4nj1 commented Feb 19, 2025

Hi,
yes that should be considered. The only issue I see is that some systems might have a different way to switch power profiles.
I have a Dell system here that supports power profiles via smbios-thermal-ctl but not via /sys/firmware/acpi/platform_profile. There it is supported only after updating to kernels >6.11.

But you are right, I will set the selected option in the UI if available in tlp-stat -p. Try to fix this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants