-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change permission status colors #9
Comments
Adjusted in 0042848 |
In dark mode, it is almost white, and in light mode it is (almost) black. Can you adjust it to have a different shade of grey in both modes? #ECECEC or #DEDEDE or #D4D4D4? Screenshot_2022-07-18-08-15-15-67_fc704e6b13c4fb26bf5e411f75da84f2 The idea is it should communicate the fact that a permission is 'disabled' or 'turned OFF'. The icons have to be visible, but NOT prominent. |
Unable to add image in comments during edit. Dark Mode: Screenshot_2022-07-18-08-25-16-30_40deb401b9ffe8e1df2f1cc5ba480b12 |
At the moment, these don't look that good: Screenshot_2022-07-18-08-28-15-02_ce34de6323cfaeb7a2880d42987990b1 Screenshot_2022-07-18-08-28-34-00_ce34de6323cfaeb7a2880d42987990b1 |
The grey status icons look great now in the Apps tab. Thank you. However, for permission authorization in the Permissions screen, can you revert to the light orange colour that you used earlier? The orange colour looks good on both light and dark themes. In fact, that green and orange combo looks great. You can use the same green for the status icons too in the Apps screen (disabled status icon should remain grey though, as it is now). In summary: Green and Grey status icons in Apps Tab. |
Hm isn't it confusing if we use two different colors for the same state? I also like that it's no longer a "bad" or "good" color. Mystic Perm should not judge whether it is bad or good that permission are granted. |
That's what I wanted to avoid earlier. But at that time, I had not seen how it would actually look like in the app. In v.0.2.4, the permissions page isn't using the grey colour that has been implemented in the Apps tab. It is using Black in light theme and white in dark theme, which looks awkward. Can you change those to the same grey colour and see how it looks? The choice of colours must be such that it looks good in both themes (light and dark), as well as communicates the message intended very intuitively.
It never was meant to be that way. A green colour signifies an allowed permission, not good or bad. Likewise, the orange colour doesn't signify anything bad. It's just that on the Apps tab, it could have been confusing since there are no markers inside (the tick mark inside green circle or the hyphen inside the orange circle). You are not using these markers in the Apps tab, so it was suggested that you make them look like the System Quick Settings, where enabled toggles are in colour, while the disabled ones are greyed out. Nothing again with anything being good or bad. |
Originally posted by @TheMysticS in #1 (comment)
The text was updated successfully, but these errors were encountered: