Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch baked file system #79

Open
da1nerd opened this issue May 24, 2020 · 5 comments
Open

patch baked file system #79

da1nerd opened this issue May 24, 2020 · 5 comments
Assignees
Labels
critical If we don't fix this something will break wontfix This will not be worked on

Comments

@da1nerd
Copy link
Owner

da1nerd commented May 24, 2020

The nightly builds are failing because IO.write now returns the number of bytes written.
The writer at https://github.com/schovi/baked_file_system/blob/master/src/loader/string_encoder.cr#L20 is not returning the number of bytes.

@da1nerd da1nerd self-assigned this May 24, 2020
@da1nerd da1nerd added the critical If we don't fix this something will break label May 24, 2020
@da1nerd
Copy link
Owner Author

da1nerd commented May 24, 2020

at first glance we could just return slice.size, however, it's not always writing everything in the slice.
Also, I'm not sure what going on here https://github.com/schovi/baked_file_system/blob/master/src/loader/string_encoder.cr#L37

@da1nerd
Copy link
Owner Author

da1nerd commented May 24, 2020

this to_s method is deprecated https://github.com/schovi/baked_file_system/blob/master/src/loader/string_encoder.cr#L39.

See https://crystal-lang.org/api/master/Int.html#to_s(base:Int,io:IO,upcase:Bool=false):Nil-instance-method

This is writing the string to the IO as an uppercase. we'll need to count that as well.

@da1nerd
Copy link
Owner Author

da1nerd commented May 24, 2020

I think there is some gzip stuff that needs to be updated as well.

@da1nerd da1nerd closed this as completed Jun 10, 2020
@da1nerd
Copy link
Owner Author

da1nerd commented Jun 10, 2020

There's already a PR open for this schovi/baked_file_system#36

@da1nerd da1nerd reopened this Jun 10, 2020
@da1nerd
Copy link
Owner Author

da1nerd commented Jun 15, 2020

The core feature that caused this break is being reverted. See crystal-lang/crystal#9469

@da1nerd da1nerd added the wontfix This will not be worked on label Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical If we don't fix this something will break wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant