-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
float type conversion #146
Comments
Hello! May I know what trouble is causing you this conversion? As far as I remember, float64 caused the export to binary formats (i.e ply) to fail. That was the main reason to force the conversion in I think that the conversion could be easily converted to optional at instantiation. For example, you could add an attribute to be setted in if self.force_float32:
convert_columns_dtype(self.points, np.float64, np.float32) That is just one idea. I would definitely look into why the conversion happens in other places than |
Hi, Your suggestion for an attribute was along the lines of what I had in mind, too. I'll continue my testing and see if I can figure out the float64 problem in case I encounter it. |
The problem I found was that even though I could export/import PLY files with float64 values inside pyntcloud, those files weren't correctly loaded in other programs such as Three.js or CloudCompare so I just decided to force the float32 conversion because any of the logic in pyntcloud was affected by that. |
Ok, so I guess my best option is to implement a conditional conversion (default: enabled). |
I was reviewing the code base and I think that the dtype conversion can be moved to the |
Hi,
Was there a particular reason you decided to do the float64->float32 conversion (other than the obvious memory consumption) ?
Can you think of a way to make this conversion optional?
The text was updated successfully, but these errors were encountered: