Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "get bot approvals" check should verify the status of the latest approval isn't "dismissed" #17

Open
dabrady opened this issue Jul 23, 2022 · 0 comments
Open

The "get bot approvals" check should verify the status of the latest approval isn't "dismissed" #17

dabrady opened this issue Jul 23, 2022 · 0 comments

Comments

@dabrady
Copy link
Owner

dabrady commented Jul 23, 2022 •
edited
Loading

If a PR is auto-approved by the bot, and then that review is dismissed, subsequent executions of the GitHub App won't notice the dismissal: the app only looks for the presence of a review submitted by the bot at some point.

We need to update the logic so that a) it only looks at the latest review, and b) it checks that review was an approval.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dabrady