change default values and add keyfreq-merge feature #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @zimoun, I'll take a look to this in these days. |
| Else it uses this value of file to save TABLE, not considering the stats already store." | ||
|
|
||
| ;; default argument | ||
| (setq load-previous-stats nil) |
There was a problem hiding this comment.
Should load-previous-stats be defined in a (let...) block?
|
Added. However, there is still two issues:
I am working on it, to fix that. Otherwise, it does not make sense. Sorry for this partial PR. |
|
My bad, sorry ! The second issue is know fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit fixes #7.
The second commit fixes #12, at least, it adds a new function able to merge two stats' files, following my proposal in the disucssion in #12.
It is just some tweaks around the existing functions
keyfreq-table-loadandkeyfreq-table-save.It should work on the fly, using the already in-place lock mechanism.